fix: boolean type into SQL 'in' operator

[zhaoyongjie]

SUMMARY

closes: #16081
Currently, there is an issue with filters that handle boolean values. If the database engine does not provide boolean value implicit conversion, will cause the query to fail.
Imagine SQL:

SELECT case
           when gender = 'boy' then True
           else False
       end AS boolean_gender,
       count(num) AS "COUNT(num)"
FROM birth_names
WHERE case
          when gender = 'boy' then True
          else False
      end IN ('false')
GROUP BY case
             when gender = 'boy' then True
             else False
         end
ORDER BY "COUNT(num)" DESC
LIMIT 10000;

the derived column(Calculated column in Superset) type is Boolean, and the operand is String('true')

case
    when gender = 'boy' then True
    else False
end IN ('false')

This PR introduced a conversion when the column type is boolean and operand type also is boolean.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

boolean.value.into.in.operator.mov

TESTING INSTRUCTIONS

1. select birth_names dataset
2. create a new Calculated Columns.
   name: boolean_gender
   SQL expression : case when gender = 'boy' then True else False end
   Data Type: Boolean
3. create a treemap v2. select boolean_gender into Group by control; select sum(num) into Metric; check emit dashboard cross filters; saved to new dashboard test
4. create a table. select boolean_gender into Group by control; select sum(num) into Metric; check emit dashboard cross filters; saved to dashboard test
5. goto dashboard test
6. select true or false in treemap v2, then the table can be filtered.
7. double-check view query in table viz, where clause like below:

WHERE case
          when gender = 'boy' then True
          else False
      end IN (false)

ADDITIONAL INFORMATION

• Has associated issue: [cross-filtering] treemap not emitting boolean column correctly #16081
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[zhaoyongjie]

bycatch: added boolean type in the UI

[codecov]

Codecov Report

Merging #16107 (de3adaa) into master (490890d) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #16107      +/-   ##
==========================================
- Coverage   76.88%   76.62%   -0.27%     
==========================================
  Files         995      995              
  Lines       52864    52892      +28     
  Branches     6712     6721       +9     
==========================================
- Hits        40644    40528     -116     
- Misses      11994    12139     +145     
+ Partials      226      225       -1     

Flag	Coverage Δ
hive	?
javascript	71.21% <100.00%> (-0.09%)	⬇️
mysql	81.60% <100.00%> (+0.04%)	⬆️
postgres	81.62% <100.00%> (+<0.01%)	⬆️
presto	?
python	81.71% <100.00%> (-0.43%)	⬇️
sqlite	81.22% <100.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erset-frontend/src/datasource/DatasourceEditor.jsx	74.25% <100.00%> (ø)
superset/connectors/base/models.py	88.14% <100.00%> (+0.07%)	⬆️
superset/utils/core.py	88.18% <100.00%> (-0.04%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.80% <0.00%> (-16.87%)	⬇️
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx	46.42% <0.00%> (-14.69%)	⬇️
...ols/DndColumnSelectControl/utils/optionSelector.ts	34.61% <0.00%> (-11.54%)	⬇️
superset/db_engine_specs/presto.py	83.47% <0.00%> (-6.49%)	⬇️
...onalFormattingControl/FormattingPopoverContent.tsx	29.26% <0.00%> (-4.07%)	⬇️
...src/dashboard/components/PropertiesModal/index.jsx	83.09% <0.00%> (-2.52%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490890d...de3adaa. Read the comment docs.

[github-actions]

@junlincc Ephemeral environment spinning up at http://34.212.23.106:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[villebro]

LGTM with one non-blocking recommendation

[villebro]

Nit: I would also add this as it seems to be missing

>>> cast_to_boolean('True')
True

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷 2021.31