Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): revert dnd column dependency array change to fix infinite rerenders #16115

Merged
merged 3 commits into from Aug 6, 2021
Merged

fix(explore): revert dnd column dependency array change to fix infinite rerenders #16115

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d71519b
fix(explore): revert dnd column dependency array change to fix infini…
kgabryje Aug 6, 2021
a7446e0
Remove console.log
kgabryje Aug 6, 2021
f825c5f
Remove comment
kgabryje Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ export const DndColumnSelect = (props: LabelProps) => {
}
// when options change, that means that the dataset has changed
// so we have to check if values are still applicable.
}, [options, value, optionSelector]);
}, [JSON.stringify(value), JSON.stringify(optionSelector.getValues())]);

// useComponentDidUpdate to avoid running this for the first render, to avoid
// calling onChange when the initial value is not valid for the dataset
Expand Down