-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new dev commands to Makefile #16327
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ update-py: | |
|
||
update-js: | ||
# Install js packages | ||
cd superset-frontend; npm install | ||
cd superset-frontend; npm ci | ||
|
||
venv: | ||
# Create a virtual environment and activate it (recommended) | ||
|
@@ -81,3 +81,9 @@ py-lint: pre-commit | |
|
||
js-format: | ||
cd superset-frontend; npm run prettier | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
|
||
flask-app: | ||
flask run -p 8088 --with-threads --reload --debugger | ||
|
||
node-app: | ||
cd superset-frontend; npm run dev-server | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Running the command you still land in the root just tested it locally so we don't need to change it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion; instead of using
cd
do this:This will bring back the user to the directory they were when they ran the command.