fix: Fix parsing onSaving reports toast when user hasn't saved chart #16330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
AAfghahi
approved these changes
Aug 18, 2021
eschutho
reviewed
Aug 18, 2021
superset/reports/commands/base.py
Outdated
| @@ -60,4 +61,4 @@ def validate_chart_dashboard( | |||
| exceptions.append(DashboardNotFoundValidationError()) | |||
| self._properties["dashboard"] = dashboard | |||
| elif not update: | |||
| exceptions.append(ReportScheduleChartOrDashboardValidationError()) | |||
| exceptions.append(ChartNotSavedValidationError()) | |||
There was a problem hiding this comment.
is it possible that this could be a dashboard?
There was a problem hiding this comment.
From my understanding dashboards would always be saved and have a record in the metastore, but for a more defensive approach i'll make a specific condition for both dashboards and charts just in case.
Codecov Report
@@ Coverage Diff @@
## master #16330 +/- ##
==========================================
- Coverage 76.63% 76.58% -0.06%
==========================================
Files 1000 1000
Lines 53424 53465 +41
Branches 6818 6816 -2
==========================================
+ Hits 40943 40944 +1
- Misses 12245 12285 +40
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Looks great! We should also disable the report button if the user hasn't saved the chart, and have a tooltip that tells them to save it.
cc: @yousoph
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Aug 24, 2021
* master: (582 commits) feat: config to customize bootstrap data overrides (apache#16386) fix: regex for multi-region IPs (apache#16410) chore: Changes the DatabaseSelector to use the new Select component (apache#16334) chore: Displays the dataset description in a tooltip in the datasets list (apache#16392) fix(pylint): Fix master (apache#16405) chore(pylint): Enable useless-suppression check (apache#16388) feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361) initial commit (apache#16366) fix: big number default date format (apache#16383) initial commit (apache#16380) fix: import dashboard w/o metadata (apache#16360) test: Functional RTL for email report modal II (apache#16148) fix: update table ID in query context on chart import (apache#16374) docs: document FLASK_APP_MUTATOR (apache#16286) feat: Add new dev commands to Makefile (apache#16327) fix: call external metadata endpoint with correct rison object (apache#16369) fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330) fix: columns/index rebuild (apache#16355) chore(viz): bump deckgl plugin to 0.4.11 (apache#16353) fix: Blank space in Change dataset modal without warning message (apache#16324) ... # Conflicts: # superset/app.py # superset/models/dashboard.py # tests/integration_tests/charts/filter_sets/__init__.py # tests/integration_tests/charts/filter_sets/conftest.py # tests/integration_tests/charts/filter_sets/consts.py # tests/integration_tests/charts/filter_sets/create_api_tests.py # tests/integration_tests/charts/filter_sets/delete_api_tests.py # tests/integration_tests/charts/filter_sets/get_api_tests.py # tests/integration_tests/charts/filter_sets/update_api_tests.py # tests/integration_tests/charts/filter_sets/utils.py # tests/integration_tests/superset_test_config.py
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…pache#16330) * don't maniuplate error message * remove extra idx reference * u * change print * update with test * add case for dashboards * fix test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…pache#16330) * don't maniuplate error message * remove extra idx reference * u * change print * update with test * add case for dashboards * fix test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove extra index when parsing errors to render to user. This was specfically happening when users would try to create a report without saving the chart
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION