Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Displays the dataset description in a tooltip in the datasets list #16392

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Aug 21, 2021

SUMMARY

Closes #16309

@junlincc @jinghua-qa @rusackas @zhxjdwh @mistercrunch

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-21.at.3.17.46.PM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #16392 (2daa2bc) into master (3faf653) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16392      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.01%     
==========================================
  Files        1000     1000              
  Lines       53489    53493       +4     
  Branches     6816     6818       +2     
==========================================
+ Hits        40957    40959       +2     
- Misses      12296    12298       +2     
  Partials      236      236              
Flag Coverage Δ
javascript 70.88% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 69.41% <33.33%> (-0.65%) ⬇️
...rset-frontend/src/components/InfoTooltip/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faf653...2daa2bc. Read the comment docs.

@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://35.166.203.100:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM!

@michael-s-molina michael-s-molina merged commit 0cdc767 into apache:master Aug 23, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@zhxjdwh
Copy link
Contributor

zhxjdwh commented Aug 24, 2021

i don't think this is good solution!!!!!!

@rusackas
Copy link
Member

i don't think this is good solution!!!!!!

Could you elaborate as to why, or what alternate approach you would suggest?

@zhxjdwh
Copy link
Contributor

zhxjdwh commented Aug 24, 2021

@rusackas
I think we should add a field "display name" for dataset/table , and add a column for "display name" field in datasets list page!

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
@michael-s-molina
Copy link
Member Author

i don't think this is good solution!!!!!!
I think we should add a field "display name" for dataset/table , and add a column for "display name" field in datasets list page!

@zhxjdwh @rusackas @junlincc I think we need to separate the features a little bit:

  • One feature, which is the objective of this PR, is to present the description of the datasets in the list. Similar to what we have when creating a chart.
  • Another feature is to present an alternative name or display name for a dataset when the name is unfriendly for non-English users. Here I'm inclined to agree with @zhxjdwh that the use of the description is not the ideal solution. The user would be forced to hover on each dataset until he finds what he was looking for. We also need to consider that the solution is not only adding a column to the list with the alternative name. We need to change all the places where the dataset is displayed to show the display name instead of the original name. This includes Explore, Add Chart, searching, etc.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[listview]add dataset description to dataset listview on hovering
6 participants