chore: removing use of supersetTheme in favor of ThemeProvider

[rusackas]

SUMMARY

For ErrorAlert and BasicErrorAlert this PR removes direct use of supersetTheme in favor of the useTheme hook and the ThemeProvider component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

there should be no discernable change

TESTING INSTRUCTIONS

Make sure errors look OK in the ephemeral environment.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17000 (f85f8e7) into master (cde4cdc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17000   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files        1030     1030           
  Lines       55031    55033    +2     
  Branches     7465     7465           
=======================================
+ Hits        42336    42340    +4     
+ Misses      12441    12439    -2     
  Partials      254      254           

Flag	Coverage Δ
hive	81.45% <ø> (ø)
javascript	70.90% <100.00%> (+<0.01%)	⬆️
mysql	81.90% <ø> (ø)
postgres	81.91% <ø> (ø)
presto	81.78% <ø> (+<0.01%)	⬆️
python	82.42% <ø> (+<0.01%)	⬆️
sqlite	81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/components/ErrorMessage/BasicErrorAlert.tsx	100.00% <100.00%> (ø)
...rontend/src/components/ErrorMessage/ErrorAlert.tsx	94.23% <100.00%> (+0.11%)	⬆️
superset/db_engine_specs/presto.py	90.37% <0.00%> (+0.41%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde4cdc...f85f8e7. Read the comment docs.

[kgabryje]

Lgtm

[villebro]

What on earth is pullapprove? I can't find any references to it in our CI confs..

[kgabryje]

What on earth is pullapprove? I can't find any references to it in our CI confs..

I haven't seen it before either...

[villebro]

What on earth is pullapprove? I can't find any references to it in our CI confs.. ![image](https://user->
I haven't seen it before either...

I'm going to do some quick investigation into this

[villebro]

It appears this has been added some time ago, but never implemented: https://issues.apache.org/jira/browse/INFRA-18241 I wonder if we should just pull it (pun intended)?

[villebro]

Actually, let's not remove it, this could be leveraged to customize our PR review process more. I'll open a draft to test how this could be used.