fix: Allow chart owners to edit title

[belgren]

SUMMARY

I added an additional condition to the logic that sets the canEdit prop of the EditableTitle component to explicitly allow owners of the chart to edit the title.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

There are no demonstrable changes - this new case uses the existing 'edit title' functionality.

TESTING INSTRUCTIONS

• As a user viewing a saved chart that you own, confirm that a 'Click to edit' tooltip now appears when hovering over the char title.
• Confirm that you can click on the title field and edit the value.

ADDITIONAL INFORMATION

• Has associated issue: Fixes #16995
• Required feature flags:
• Changes UI: The previously existing 'Edit title' feature is now accessible in additional cases.
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[geido]

Thanks for the contribution @belgren! I am running the CI now to see if it passes.

[codecov]

Codecov Report

Merging #17047 (83af3e7) into master (7c1c89c) will increase coverage by 0.02%.
The diff coverage is 70.22%.

❗ Current head 83af3e7 differs from pull request most recent head 1739814. Consider uploading reports for the commit 1739814 to get more accurate results

@@            Coverage Diff             @@
##           master   #17047      +/-   ##
==========================================
+ Coverage   76.91%   76.93%   +0.02%     
==========================================
  Files        1031     1039       +8     
  Lines       55163    55587     +424     
  Branches     7501     7580      +79     
==========================================
+ Hits        42428    42766     +338     
- Misses      12483    12571      +88     
+ Partials      252      250       -2     

Flag	Coverage Δ
javascript	70.98% <68.75%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx	81.86% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js	1.70% <ø> (+0.01%)	⬆️
...frontend/src/dashboard/components/Header/index.jsx	68.71% <0.00%> (-0.78%)	⬇️
...ilters/FilterBar/FilterConfigurationLink/index.tsx	100.00% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx	88.88% <0.00%> (-4.14%)	⬇️
.../nativeFilters/FilterBar/FilterSets/utils/index.ts	100.00% <ø> (ø)
...nativeFilters/FiltersConfigModal/Footer/Footer.tsx	90.90% <0.00%> (-9.10%)	⬇️
...mponents/nativeFilters/FiltersConfigModal/state.ts	81.25% <0.00%> (+4.77%)	⬆️
...rontend/src/dashboard/containers/DashboardPage.tsx	0.00% <0.00%> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts	62.16% <0.00%> (+2.16%)	⬆️
... and 121 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1c89c...1739814. Read the comment docs.

[geido]

Re-running CI. Got stuck

[geido]

LGTM!

[belgren]

@geido Thanks for the review! Is this ready to be merged?