-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow chart owners to edit title #17047
Conversation
Thanks for the contribution @belgren! I am running the CI now to see if it passes. |
Codecov Report
@@ Coverage Diff @@
## master #17047 +/- ##
==========================================
+ Coverage 76.91% 76.93% +0.02%
==========================================
Files 1031 1039 +8
Lines 55163 55587 +424
Branches 7501 7580 +79
==========================================
+ Hits 42428 42766 +338
- Misses 12483 12571 +88
+ Partials 252 250 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Re-running CI. Got stuck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@geido Thanks for the review! Is this ready to be merged? |
SUMMARY
I added an additional condition to the logic that sets the
canEdit
prop of theEditableTitle
component to explicitly allow owners of the chart to edit the title.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
There are no demonstrable changes - this new case uses the existing 'edit title' functionality.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION