-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Fix update ownState #17181
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #17181 +/- ##
==========================================
+ Coverage 76.89% 76.94% +0.04%
==========================================
Files 1038 1038
Lines 55515 55613 +98
Branches 7564 7588 +24
==========================================
+ Hits 42690 42793 +103
+ Misses 12575 12570 -5
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but curious if you agree with the refactoring proposal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing + making the code more readable!
…che#17311) This reverts commit cf284ba. (cherry picked from commit 7c6d6f4)
* fix:fix get permission function * fix: fix own state update * refactor: fix CR notes (cherry picked from commit cf284ba)
SUMMARY
Steps to reproduce(description):
setDataMask({ ownState: {} })
)ownState
it reloads all other charts on first timeIssue: when we check if need reload other charts we auto reload all charts in case if in list of active filters added new chart(filter), but when we add only
ownState
, regarding that we added this chart in list of filters it doesn't emit values for other charts, only for itself, so we need to check if it has values emitted outside of this chartBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION