Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Fix update ownState #17181

Merged
merged 24 commits into from
Oct 26, 2021
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6eb04b1
fix:fix get permission function
simcha90 Apr 13, 2021
5e9a1d8
Merge branch 'master' of github.com:apache/superset
simcha90 Apr 18, 2021
2c5800a
Merge branch 'master' of github.com:apache/superset
simcha90 Apr 20, 2021
ea9aa8b
Merge branch 'master' of github.com:apache/superset
simcha90 Apr 25, 2021
402918a
Merge branch 'master' of github.com:apache/superset
simcha90 Apr 27, 2021
1a3cc39
Merge branch 'master' of github.com:apache/superset
simcha90 Apr 28, 2021
f6d4590
Merge branch 'master' of github.com:apache/superset
simcha90 May 10, 2021
97f2c15
Merge branch 'master' of github.com:apache/superset
simcha90 May 24, 2021
1f31df7
Merge branch 'master' of github.com:apache/superset
simcha90 May 24, 2021
dce7b7a
Merge branch 'master' of github.com:apache/superset
simcha90 May 26, 2021
0334f35
Merge branch 'master' of github.com:apache/superset
simcha90 May 30, 2021
f6dd314
Merge branch 'master' of github.com:apache/superset
simcha90 Jun 17, 2021
64267e1
Merge branch 'master' of github.com:apache/superset
simcha90 Jun 20, 2021
385eddc
Merge branch 'master' of github.com:apache/superset
simcha90 Jun 24, 2021
51a00a3
Merge branch 'master' of github.com:apache/superset
simcha90 Jul 1, 2021
4e94cb5
Merge branch 'master' of github.com:apache/superset
simcha90 Jul 4, 2021
e7fa0a6
Merge branch 'master' of github.com:apache/superset
simcha90 Jul 7, 2021
c3d24d7
Merge branch 'master' of github.com:apache/superset
simcha90 Aug 31, 2021
a3893a4
Merge branch 'master' of github.com:apache/superset
simcha90 Sep 29, 2021
30c516b
Merge branch 'master' of github.com:apache/superset
simcha90 Oct 5, 2021
03165d1
Merge branch 'master' of github.com:apache/superset
simcha90 Oct 7, 2021
9d86002
Merge branch 'master' of github.com:apache/superset
simcha90 Oct 17, 2021
82dea25
fix: fix own state update
simcha90 Oct 21, 2021
e63f695
refactor: fix CR notes
simcha90 Oct 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions superset-frontend/src/dashboard/components/Dashboard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,16 @@ class Dashboard extends React.PureComponent {
);
[...allKeys].forEach(filterKey => {
if (
!currFilterKeys.includes(filterKey) &&
appliedFilterKeys.includes(filterKey)
) {
// filterKey is removed?
affectedChartIds.push(...appliedFilters[filterKey].scope);
} else if (!appliedFilterKeys.includes(filterKey)) {
(!currFilterKeys.includes(filterKey) &&
appliedFilterKeys.includes(filterKey)) ||
// filterKey is newly added?
affectedChartIds.push(...activeFilters[filterKey].scope);
!appliedFilterKeys.includes(filterKey)
) {
// check if there are values in filter, if no, there is was added only ownState, so no need reload other charts
if (Object.keys(appliedFilters[filterKey]?.values ?? []).length) {
affectedChartIds.push(...appliedFilters[filterKey].scope);
}
simcha90 marked this conversation as resolved.
Show resolved Hide resolved
} else {
// if filterKey changes value,
// update charts in its scope
Expand Down