Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(QueryObject): decouple from superset #17479

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Nov 18, 2021

Background

When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest.
All chartData flows and its components are too couple to superset so it is impossible to create unittests.
The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty

So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow

This is the ninth PR in a sequence of PRs to meet these
The next PR is #17495

PR description

  1. Decoupling query_object module and Class from Superset
  2. adding common fixture utils to create query_context payload for integration and unit_tests
  3. moving tests from integration_tests to unit_tests (from TestSchema to TestQueryObjectFactory)

Test plans

There is no logic added so new tests are not required

Previous PRs

  1. refactor(ChartData): move ChartDataResult enums to common #17399
  2. refactor(ChartData): move chart_data_apis from ChartRestApi ChartDataRestApi #17400
  3. refactor(ChartDataCommand): separate loading query_context form cache into different module #17405
  4. refactor(TestChartApi): move chart data api tests into TestChartDataApi #17407
  5. refactor(ChartDataCommand): into two separate commands #17425
  6. refactor(ChartDataCommand): remove create queryContext command's responsibly  #17461
  7. refactor(QueryObject): decouple from queryContext and clean code #17465
  8. refactor(QueryObject): add QueryObjectFactory to meet SRP #17466

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #17479 (9dc39fa) into master (377db1b) will increase coverage by 0.00%.
The diff coverage is 91.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17479   +/-   ##
=======================================
  Coverage   76.87%   76.88%           
=======================================
  Files        1042     1043    +1     
  Lines       56345    56369   +24     
  Branches     7793     7793           
=======================================
+ Hits        43316    43337   +21     
- Misses      12773    12776    +3     
  Partials      256      256           
Flag Coverage Δ
hive 81.53% <91.07%> (+<0.01%) ⬆️
mysql 81.96% <91.07%> (+<0.01%) ⬆️
postgres 81.97% <91.07%> (+<0.01%) ⬆️
python 82.32% <91.07%> (+<0.01%) ⬆️
sqlite 81.64% <91.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_object_factory.py 89.79% <89.79%> (ø)
superset/common/query_context.py 92.00% <100.00%> (+0.10%) ⬆️
superset/common/query_object.py 93.06% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377db1b...9dc39fa. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decoupling of query object from superset shows value already by having simple unit-tests for the query_object factory, Nice!

@amitmiran137 amitmiran137 merged commit 683d1da into apache:master Nov 18, 2021
@amitmiran137 amitmiran137 deleted the refactor/chart_data_flows_9 branch November 21, 2021 10:22
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* refactor: queryObject - decouple from superset

* refactor: queryObject - decouple from superset
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants