refactor(QueryContext): move df methods utils to utils package #17496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17496 +/- ##
==========================================
- Coverage 76.90% 76.76% -0.14%
==========================================
Files 1044 1045 +1
Lines 56435 56441 +6
Branches 7798 7798
==========================================
- Hits 43399 43327 -72
- Misses 12780 12858 +78
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Nov 21, 2021
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* chore(common.utils): modified utils from module based to package based * refactor(common.utils): move QueryCacheManager to ad-hoc module * refactor(QueryContext): move df method utils to utils module
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest.
All chartData flows and its components are too couple to superset so it is impossible to create unittests.
The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty
So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow
This is the Eleventh PR in a sequence of PRs to meet these
The next PR is #17497
PR description
QueryContext class contains static methods used as Dataframe utils. To meet SRP, those methods moved to a utils package.
to keep the utils meeting SRP, it implies arranging the utils to be as package and separating each of the related methods into ad hoc modules.
Test plans
There is no logic added so new tests are not required
Previous PRs