Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embedded dashboard core #17530

Merged
merged 14 commits into from
Jan 26, 2022
Merged

feat: embedded dashboard core #17530

merged 14 commits into from
Jan 26, 2022

Commits on Nov 16, 2021

  1. feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

    * setup embedded provider
    
    * update ui configuration
    
    * fix test
    Lily Kuang committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    7108e6b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    71421e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Configuration menu
    Copy the full SHA
    68795a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Configuration menu
    Copy the full SHA
    d2e088c View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Configuration menu
    Copy the full SHA
    ee71eb8 View commit details
    Browse the repository at this point in the history
  2. feat: Guest token (for embedded dashboard auth) (#17517)

    * generate an embed token
    
    * improve existing tests
    
    * add some auth setup, and rename token
    
    * fix the stuff for compatibility with external request loaders
    
    * docs, standard jwt claims, tweaks
    
    * black
    
    * lint
    
    * tests, and safer token decoding
    
    * linting
    
    * type annotation
    
    * prettier
    
    * add feature flag
    
    * quiet pylint
    
    * apparently typing is a problem again
    
    * Make guest role name configurable
    
    * fake being a non-anonymous user
    
    * just one log entry
    
    * customizable algo
    
    * lint
    
    * lint again
    
    * 403 works now!
    
    * get guest token from header instead of cookie
    
    * Revert "403 works now!"
    
    This reverts commit df2f49a.
    
    * fix tests
    
    * Revert "Revert "403 works now!""
    
    This reverts commit 883dff3.
    
    * rename method
    suddjian committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    d705236 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Configuration menu
    Copy the full SHA
    d2774e4 View commit details
    Browse the repository at this point in the history
  2. correct import

    suddjian committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    4c74e53 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. feat: entry for embedded dashboard (#17529)

    * create entry for embedded dashboard in webpack
    
    * add cookies
    
    * lint
    
    * token message handshake
    
    * guestTokenHeaderName
    
    * use setupClient instead of calling configure
    
    * rename the webpack chunk
    
    * simplified handshake
    
    * embedded entrypoint: render a proper app
    
    * make the embedded page accept anonymous connections
    
    * format
    
    * lint
    
    * fix test
    # Conflicts:
    #	superset-frontend/src/embedded/index.tsx
    #	superset/views/core.py
    
    * lint
    
    * Update superset-frontend/src/embedded/index.tsx
    
    Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
    
    * comment out origins checks
    
    * move embedded for core to dashboard
    
    * pylint
    
    * isort
    
    Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
    Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
    3 people committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    fe63435 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge branch 'master' into embedded

    Lily Kuang committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    8f2bba9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. feat: Authorizing guest access to embedded dashboards (#17757)

    * helper methods and dashboard access
    
    * guest token dashboard authz
    
    * adjust csrf exempt list
    
    * eums don't work that way
    
    * Remove unnecessary import
    
    * move row level security tests to their own file
    
    * a bit of refactoring
    
    * add guest token security tests
    
    * refactor tests
    
    * clean imports
    
    * variable names can be too long apparently
    
    * missing argument to get_user_roles
    
    * don't redefine builtins
    
    * remove unused imports
    
    * fix test import
    
    * default to global user when getting roles
    
    * missing import
    
    * mock it
    
    * test get_user_roles
    
    * infer g.user for ease of tests
    
    * remove redundant check
    
    * tests for guest user security manager fns
    
    * use algo to get rid of warning messages
    
    * tweaking access checks
    
    * fix guest token security tests
    
    * missing imports
    
    * more tests
    
    * more testing and also some small refactoring
    
    * move validation out of parsing
    
    * fix dashboard access check again
    
    * add more test
    
    Co-authored-by: Lily Kuang <lily@preset.io>
    suddjian and Lily Kuang committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    7b804f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. feat: Row Level Security rules for guest tokens (#17836)

    * helper methods and dashboard access
    
    * guest token dashboard authz
    
    * adjust csrf exempt list
    
    * eums don't work that way
    
    * Remove unnecessary import
    
    * move row level security tests to their own file
    
    * a bit of refactoring
    
    * add guest token security tests
    
    * refactor tests
    
    * clean imports
    
    * variable names can be too long apparently
    
    * missing argument to get_user_roles
    
    * don't redefine builtins
    
    * remove unused imports
    
    * fix test import
    
    * default to global user when getting roles
    
    * missing import
    
    * mock it
    
    * test get_user_roles
    
    * infer g.user for ease of tests
    
    * remove redundant check
    
    * tests for guest user security manager fns
    
    * use algo to get rid of warning messages
    
    * tweaking access checks
    
    * fix guest token security tests
    
    * missing imports
    
    * more tests
    
    * more testing and also some small refactoring
    
    * move validation out of parsing
    
    * fix dashboard access check again
    
    * rls rules for guest tokens
    
    * test guest token rls rules
    
    * more flexible rls rules
    
    * lint
    
    * fix tests
    
    * fix test
    
    * defaults
    
    * fix some tests
    
    * fix some tests
    
    * lint
    
    Co-authored-by: Lily Kuang <lily@preset.io>
    suddjian and Lily Kuang committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    ea92d57 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Configuration menu
    Copy the full SHA
    8fb08b1 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Lily Kuang <lily@preset.io>
    suddjian and Lily Kuang committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    e3dc5ee View commit details
    Browse the repository at this point in the history