-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contribuing docs #17754
Conversation
@riahk can you take a look at these changes? FYI @zhaoyongjie , Moriah is moving these sections into the docs section, so in the future the majority of this will be featured in the official documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One slight nit. Thank you for this!
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]: | |||
return math.sqrt(x) | |||
``` | |||
|
|||
### TypeScript | |||
### TypeScript Typing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit redundant imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION