chore(generator-superset): migrate to monorepo #17829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
reviewed
Dec 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #17829 +/- ##
==========================================
- Coverage 67.17% 67.15% -0.02%
==========================================
Files 1609 1608 -1
Lines 64796 64801 +5
Branches 6855 6851 -4
==========================================
- Hits 43528 43519 -9
- Misses 19412 19423 +11
- Partials 1856 1859 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
reviewed
Dec 21, 2021
zhaoyongjie
reviewed
Dec 21, 2021
| @@ -0,0 +1,20 @@ | |||
| const { getConfig } = require('@airbnb/config-babel'); | |||
There was a problem hiding this comment.
Is it possible to use babel config without airbnb/config-babel?
There was a problem hiding this comment.
It seems to bring in a bunch of good defaults (would otherwise have to do lots of other configs here), so I think it's a good idea to use it.
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* chore(generator-superset): migrate to monorepo * add todo and remove webpack reference from template * fix linting errors * remove redundant test file
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* chore(generator-superset): migrate to monorepo * add todo and remove webpack reference from template * fix linting errors * remove redundant test file
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the
generator-supersetYeoman generator template generates plugins that require the oldsuperset-uimonorepo. This is a first-pass at fixing the generator by changing the following:superset-uipackage - now the generator only supports creating pluginsSCREENSHOT
This plugin has been generated with the updated template:
TESTING INSTRUCTIONS
superset-frontend/packages/generator-supersetfolder and runnpm i~/srcand runmkdir superset-plugin-chart-hello-worldyo @superset-ui/supersetand answer all questionsnpm i --force && npm run build && npm run test && npm packand see that the new package works and can be packaged for npmMainPreset.jsand see it workADDITIONAL INFORMATION