-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag #18003
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag #18003
Conversation
b9a1026
to
369c34f
Compare
Codecov Report
@@ Coverage Diff @@
## master #18003 +/- ##
==========================================
+ Coverage 66.30% 66.32% +0.01%
==========================================
Files 1569 1569
Lines 61626 61661 +35
Branches 6232 6233 +1
==========================================
+ Hits 40861 40895 +34
- Misses 19166 19167 +1
Partials 1599 1599
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! CI might require some love though
369c34f
to
92578d5
Compare
Thank you! Just fixed CI issues (crossing fingers) |
Approved 🚀 |
…apache#18003) * a lot of console logs * adding new feature flag for datasource editor
…apache#18003) * a lot of console logs * adding new feature flag for datasource editor
SUMMARY
This creates a new feature flag for the legacy datasource editor that we are going to depreciate in superset 2.0. Currently it is set to False, which will show the legacy datasource editor, but it gives users the option to not have the option available anymore.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION