chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag #18003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch33567_legacyDatasourceEditor
branch
2 times, most recently
from
b9a1026
to
369c34f
Compare
Codecov Report
@@ Coverage Diff @@
## master #18003 +/- ##
==========================================
+ Coverage 66.30% 66.32% +0.01%
==========================================
Files 1569 1569
Lines 61626 61661 +35
Branches 6232 6233 +1
==========================================
+ Hits 40861 40895 +34
- Misses 19166 19167 +1
Partials 1599 1599
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geido
approved these changes
Jan 12, 2022
AAfghahi
force-pushed
the
ch33567_legacyDatasourceEditor
branch
from
369c34f
to
92578d5
Compare
Thank you! Just fixed CI issues (crossing fingers) |
|
Approved 🚀 |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…apache#18003) * a lot of console logs * adding new feature flag for datasource editor
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…apache#18003) * a lot of console logs * adding new feature flag for datasource editor
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This creates a new feature flag for the legacy datasource editor that we are going to depreciate in superset 2.0. Currently it is set to False, which will show the legacy datasource editor, but it gives users the option to not have the option available anymore.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION