fix(explore): Pie chart label formatting when series is temporal #18216
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the label formatting was deciding whether to use number formatter or time formatter, it first checked if value is a number and if not, it checked if value is Date or column type is temporal. Timestamp values are numbers, so the first condition was true and number formatter was being used for timestamps. This PR switches the order of checks so that we first check if column is temporal.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see linked issue
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @rusackas
https://app.shortcut.com/preset/story/34104/gh-13293-prod-37-pie-chart-date-format