Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): Pie chart label formatting when series is temporal #18216

Merged
merged 1 commit into from
Jan 28, 2022
+3 −3
Merged

fix(explore): Pie chart label formatting when series is temporal #18216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ export function formatSeriesName(
if (name === undefined || name === null) {
return NULL_STRING;
}
if (typeof name === 'number') {
zhaoyongjie marked this conversation as resolved.
Show resolved Hide resolved
return numberFormatter ? numberFormatter(name) : name.toString();
}
if (typeof name === 'boolean') {
return name.toString();
}
Expand All @@ -99,6 +96,9 @@ export function formatSeriesName(

return timeFormatter ? timeFormatter(d) : d.toISOString();
}
if (typeof name === 'number') {
return numberFormatter ? numberFormatter(name) : name.toString();
}
return name;
}

Expand Down