-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename and reposition native filter modal fields #18558
chore: Rename and reposition native filter modal fields #18558
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18558 +/- ##
==========================================
- Coverage 66.32% 66.29% -0.04%
==========================================
Files 1592 1595 +3
Lines 62569 62582 +13
Branches 6295 6298 +3
==========================================
- Hits 41500 41489 -11
- Misses 19416 19447 +31
+ Partials 1653 1646 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.218.60.199:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The objective of this PR is to improve the naming and organization of the native filters modal. The changes are the result of a series of interviews conducted by the design team with Superset users. This is just a subset of the proposed changes, we'll have more in follow-up PRs.
Another small change is that both sections in the Settings tab are expanded by default.
@jinghua-qa @kasiazjc Nesting and limiting will be handled by follow-up PRs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-02-02.at.2.43.36.PM.mov
Screen.Recording.2022-02-02.at.2.40.56.PM.mov
TESTING INSTRUCTIONS
All the features should continue to work as before.
ADDITIONAL INFORMATION