Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Explore): Fix cache timeout field not being saved and unit tests #18738

Merged
merged 2 commits into from
Feb 16, 2022
Merged

fix(Explore): Fix cache timeout field not being saved and unit tests #18738

merged 2 commits into from
Feb 16, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 15, 2022

SUMMARY

This PR fixes a problem for which the cache_timeout filter wasn't being saved.

It also adds unit tests for similar cases for all the fields of the Chart properties modal.

BEFORE

DEV.Most.Populated.Countries.Test.1.mp4

AFTER

DEV.Most.Populated.Countries.Test.mp4

TESTING INSTRUCTIONS

  1. Edit the Chart properties
  2. Enter the cache_timeout field
  3. Save
  4. Reopen the modal
  5. The cache_timeout field should not be empty

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #18738 (bf9a7ff) into master (167e18e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18738      +/-   ##
==========================================
- Coverage   66.34%   66.29%   -0.06%     
==========================================
  Files        1619     1620       +1     
  Lines       62961    63012      +51     
  Branches     6354     6368      +14     
==========================================
  Hits        41772    41772              
- Misses      19529    19583      +54     
+ Partials     1660     1657       -3     
Flag Coverage Δ
javascript 51.26% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/explore/components/PropertiesModal/index.tsx 70.00% <ø> (+1.66%) ⬆️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.18% <0.00%> (-21.82%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 69.82% <0.00%> (-11.05%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 57.60% <0.00%> (-1.29%) ⬇️
...src/components/FilterableTable/FilterableTable.tsx 71.42% <0.00%> (-0.60%) ⬇️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 65.47% <0.00%> (ø)
superset-frontend/src/hooks/useTabId.ts 0.00% <0.00%> (ø)
.../explore/components/ExploreViewContainer/index.jsx 57.14% <0.00%> (+0.15%) ⬆️
...dashboard/components/menu/ShareMenuItems/index.tsx 67.85% <0.00%> (+1.19%) ⬆️
...rset-frontend/src/explore/exploreUtils/formData.ts 83.33% <0.00%> (+1.51%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167e18e...bf9a7ff. Read the comment docs.

@geido geido merged commit cf8b57e into apache:master Feb 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants