Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FilterBox date endpoints to use [inclusive, exclusive) #18857

Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Feb 22, 2022

SUMMARY

The date filter display for filterboxes was not displaying the proper [inclusive, exclusive) operators. I assume this was missed at some point since all other implementations of date filters set the endpoints to ["inclusive", "exclusive"] This resolves the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-02-22 at 2 11 03 PM
Screen Shot 2022-02-22 at 2 12 38 PM

After:
Screen Shot 2022-02-22 at 2 05 12 PM
Screen Shot 2022-02-22 at 2 05 17 PM

TESTING INSTRUCTIONS

Test in dev with the filter box

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @michael-s-molina @graceguo-supercat

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #18857 (f6f528a) into master (9d5c050) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18857      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files        1621     1621              
  Lines       63057    63057              
  Branches     6382     6382              
==========================================
- Hits        41850    41847       -3     
- Misses      19547    19548       +1     
- Partials     1660     1662       +2     
Flag Coverage Δ
javascript 51.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/FilterBox/FilterBox.jsx 47.65% <ø> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 77.57% <0.00%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c050...f6f528a. Read the comment docs.

@etr2460 etr2460 merged commit 324601e into apache:master Feb 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants