Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nested-tab-available): make the another tabs into one tabs available #18877

Merged
merged 2 commits into from Mar 3, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Feb 23, 2022

SUMMARY

Unable to add Tabs inside a Tab unless the Tab already has other elements (Dashboard Layout)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-02-23 at 8 21 22 AM

After:
Screen Shot 2022-02-23 at 8 21 08 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #18877 (bd0f26b) into master (c8df849) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18877      +/-   ##
==========================================
+ Coverage   66.31%   66.32%   +0.01%     
==========================================
  Files        1620     1634      +14     
  Lines       63075    63315     +240     
  Branches     6370     6428      +58     
==========================================
+ Hits        41827    41994     +167     
- Misses      19591    19641      +50     
- Partials     1657     1680      +23     
Flag Coverage Δ
javascript 51.38% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/getDropPosition.js 88.67% <ø> (+1.40%) ⬆️
superset-frontend/src/dataMask/actions.ts 54.54% <0.00%> (-18.19%) ⬇️
...acy-preset-chart-deckgl/src/utilities/controls.jsx 11.11% <0.00%> (-8.89%) ⬇️
...perset-frontend/src/views/components/MenuRight.tsx 72.13% <0.00%> (-8.36%) ⬇️
superset-frontend/src/dataMask/reducer.ts 43.33% <0.00%> (-6.67%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 64.22% <0.00%> (-5.60%) ⬇️
...-frontend/src/components/AlteredSliceTag/index.jsx 87.69% <0.00%> (-2.64%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (-2.57%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 63.63% <0.00%> (-2.50%) ⬇️
superset-frontend/src/components/Select/Select.tsx 86.69% <0.00%> (-0.67%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...bd0f26b. Read the comment docs.

@rusackas rusackas requested a review from geido February 23, 2022 16:53
@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://52.40.162.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete the code (and the TODO) rather than commenting it out.

Also adding @williaster as a reviewer... he wrote this original check, so I'm not sure if there's rationale for the prevention of nested tabs that we'd want to preserve.

@rusackas rusackas requested a review from williaster March 1, 2022 15:30
@rusackas
Copy link
Member

rusackas commented Mar 1, 2022

Pinging @graceguo-supercat for any additional historical context on why we have this limitation, in case @williaster is unavailable.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 3, 2022
@rusackas rusackas merged commit 6fe2431 into apache:master Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
…ble (#18877)

* fix(nested-tab-available): make the another tabs into one tabs available

* fix(netsted-tab): remove code of disable nested tab

(cherry picked from commit 6fe2431)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants