Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nested-tab-available): make the another tabs into one tabs available #18877

Merged
merged 2 commits into from
Mar 3, 2022
Merged

fix(nested-tab-available): make the another tabs into one tabs available #18877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd99b7
fix(nested-tab-available): make the another tabs into one tabs available
prosdev0107 Feb 23, 2022
bd0f26b
fix(netsted-tab): remove code of disable nested tab
prosdev0107 Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions superset-frontend/src/dashboard/util/getDropPosition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,6 @@ export default function getDropPosition(monitor, Component) {
return null;
}

// TODO need a better solution to prevent nested tabs
if (
draggingItem.type === TABS_TYPE &&
component.type === TAB_TYPE &&
componentDepth === 2
) {
return null;
}

const validChild = isValidChild({
parentType: component.type,
parentDepth: componentDepth,
Expand Down