Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set force=true for exporting CSV on dashboard charts #18911

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Feb 24, 2022

SUMMARY

Set the force=true for exportChart commands on the dashboard to allow the user to pull from the source. The original issue was on CSV Exports the user would receive cached data after an update

bust-2nd-cache.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title add force condition for exporting csv fix: Set force=true for exporting CSV on dashboard charts Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #18911 (3ba2eee) into master (7345795) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18911   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files        1633     1633           
  Lines       63210    63210           
  Branches     6409     6409           
=======================================
  Hits        41852    41852           
  Misses      19698    19698           
  Partials     1660     1660           
Flag Coverage Δ
hive 52.28% <ø> (ø)
javascript 51.02% <ø> (ø)
mysql 81.55% <ø> (ø)
postgres 81.60% <ø> (ø)
presto 52.12% <ø> (ø)
python 82.04% <ø> (ø)
sqlite 81.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 57.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7345795...3ba2eee. Read the comment docs.

@hughhhh hughhhh merged commit 94e245d into master Feb 24, 2022
@eschutho eschutho added the need:qa-review Requires QA review label Feb 24, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the 2nd-cache-csv branch March 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants