-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show user email in dashboard API #19004
Conversation
d72dfc3
to
d811683
Compare
d811683
to
425cec0
Compare
Codecov Report
@@ Coverage Diff @@
## master #19004 +/- ##
===========================================
- Coverage 66.58% 52.12% -14.47%
===========================================
Files 1641 1641
Lines 63548 63548
Branches 6424 6424
===========================================
- Hits 42315 33122 -9193
- Misses 19554 28747 +9193
Partials 1679 1679
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM. please fix the tests before merge :)
* Feat: show user email in dashboard API * Fix test (cherry picked from commit be88cb9)
SUMMARY
I added the user email to the response from the dashboard API (we already return username, first and last name). This is need to sync dashboards to DBT exposures, since it requires the email of the dashboard owner.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Check the response from
/api/v1/dashboard/
, it should have the email of the owners.I updated the unit test.
ADDITIONAL INFORMATION