Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show user email in dashboard API #19004

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

I added the user email to the response from the dashboard API (we already return username, first and last name). This is need to sync dashboards to DBT exposures, since it requires the email of the dashboard owner.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Check the response from /api/v1/dashboard/, it should have the email of the owners.

I updated the unit test.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Feat: show user email in dashboard API feat: show user email in dashboard API Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #19004 (425cec0) into master (19eb73b) will decrease coverage by 14.46%.
The diff coverage is n/a.

❗ Current head 425cec0 differs from pull request most recent head 9906294. Consider uploading reports for the commit 9906294 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #19004       +/-   ##
===========================================
- Coverage   66.58%   52.12%   -14.47%     
===========================================
  Files        1641     1641               
  Lines       63548    63548               
  Branches     6424     6424               
===========================================
- Hits        42315    33122     -9193     
- Misses      19554    28747     +9193     
  Partials     1679     1679               
Flag Coverage Δ
hive 52.61% <ø> (ø)
javascript 51.38% <ø> (ø)
mysql ?
postgres ?
presto 52.45% <ø> (ø)
python 52.88% <ø> (-29.43%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 48.81% <ø> (-43.73%) ⬇️
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 22.22% <0.00%> (-77.78%) ⬇️
superset/dashboards/commands/importers/v0.py 14.79% <0.00%> (-75.15%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 17.50% <0.00%> (-75.00%) ⬇️
superset/tasks/alerts/observer.py 27.77% <0.00%> (-72.23%) ⬇️
superset/databases/commands/importers/v1/utils.py 27.77% <0.00%> (-72.23%) ⬇️
superset/datasets/commands/importers/v0.py 24.82% <0.00%> (-68.80%) ⬇️
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19eb73b...9906294. Read the comment docs.

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. please fix the tests before merge :)

@betodealmeida betodealmeida merged commit be88cb9 into master Mar 3, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* Feat: show user email in dashboard API

* Fix test

(cherry picked from commit be88cb9)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the list_email_in_dashboard_api branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants