Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "refactor: converted QueryAutoRefresh to functional component … #19226

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: Revert "refactor: converted QueryAutoRefresh to functional component … #19226

merged 2 commits into from
Mar 16, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 16, 2022 •
edited by betodealmeida
Loading

…(#18179)"

This reverts commit f497c19 because it broke async queries.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title Revert "refactor: converted QueryAutoRefresh to functional component … fix: Revert "refactor: converted QueryAutoRefresh to functional component … Mar 16, 2022
@hughhhh hughhhh merged commit fc87218 into master Mar 16, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.11

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 17, 2022
@hughhhh @sadpandajoe
fix: Revert "refactor: converted QueryAutoRefresh to functional compo…
a66e568 
…nent … (apache#19226)

* Revert "refactor: converted QueryAutoRefresh to functional component (apache#18179)"

This reverts commit f497c19.

* lint

(cherry picked from commit fc87218)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@hughhhh @villebro
fix: Revert "refactor: converted QueryAutoRefresh to functional compo…
2979ff2 
…nent … (#19226)

* Revert "refactor: converted QueryAutoRefresh to functional component (#18179)"

This reverts commit f497c19.

* lint

(cherry picked from commit fc87218)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the revert-f497c1900e896a45daac66cf35776d9ad343f69e branch March 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hughhhh @sadpandajoe @betodealmeida @mistercrunch @villebro