-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: converted QueryAutoRefresh to functional component #18179
refactor: converted QueryAutoRefresh to functional component #18179
Conversation
cb42dd5
to
68c26bb
Compare
68c26bb
to
8694429
Compare
superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx
Outdated
Show resolved
Hide resolved
48cc869
to
2a09ab7
Compare
Hey @briannguyen4 thanks for the contribution! It looks like unit tests might require some love for this to pass. |
Codecov Report
@@ Coverage Diff @@
## master #18179 +/- ##
==========================================
- Coverage 66.04% 65.99% -0.05%
==========================================
Files 1591 1620 +29
Lines 62398 62961 +563
Branches 6283 6420 +137
==========================================
+ Hits 41210 41552 +342
- Misses 19567 19747 +180
- Partials 1621 1662 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @briannguyen4, thank you!
…nent … (apache#19226) * Revert "refactor: converted QueryAutoRefresh to functional component (apache#18179)" This reverts commit f497c19. * lint (cherry picked from commit fc87218)
* converted file to functional component * refactor: convert class component to functional component * refactor: convert class component to functional" * Working on converting the shouldCheckForQueries test to RTL * Working on converting first test to RTL * Working on first test for queryAutoRefresh * Finished Tests, pushing for review * Cleaned up comments and console logs Co-authored-by: Josue Lugaro <josuelugaro15@gmail.com> (cherry picked from commit f497c19)
SUMMARY
Converted QueryAutoRefresh class component into functional component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run a query and see if the timer works.
ADDITIONAL INFORMATION