feat: add support for comments in adhoc clauses #19248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19248 +/- ##
=======================================
Coverage 66.78% 66.79%
=======================================
Files 1670 1670
Lines 64401 64425 +24
Branches 6501 6502 +1
=======================================
+ Hits 43009 43030 +21
- Misses 19708 19711 +3
Partials 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
suddjian
reviewed
Mar 18, 2022
| @@ -23,6 +23,14 @@ import { QueryObjectFilterClause } from './types/Query'; | |||
| import { isSimpleAdhocFilter } from './types/Filter'; | |||
| import convertFilter from './convertFilter'; | |||
|
|
|||
| function sanitizeClause(clause: string): string { | |||
There was a problem hiding this comment.
This needs to be done on backend, no?
suddjian
reviewed
Mar 18, 2022
| if open_parens > 0: | ||
| raise QueryClauseValidationException("Unclosed parenthesis in filter clause") | ||
|
|
||
| if previous_token and previous_token.ttype in Comment: | ||
| if previous_token.value[-1] != "\n": | ||
| clause = f"{clause}\n" |
There was a problem hiding this comment.
Ah, I see it is done in the backend. But I still don't understand why we also do this in the frontend?
suddjian
approved these changes
Mar 18, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 18, 2022
* feat: add support for comments in adhoc clauses * sanitize remaining freeform clauses * sanitize adhoc having in frontend * address review comment (cherry picked from commit f341025)
|
🏷️ preset:2022.11 |
villebro
added a commit
that referenced
this pull request
Mar 21, 2022
* feat: add support for comments in adhoc clauses * sanitize remaining freeform clauses * sanitize adhoc having in frontend * address review comment
yangfei4913438
pushed a commit
to choice-form/superset
that referenced
this pull request
Apr 2, 2022
* feat: add support for comments in adhoc clauses * sanitize remaining freeform clauses * sanitize adhoc having in frontend * address review comment
villebro
added a commit
that referenced
this pull request
Apr 3, 2022
* feat: add support for comments in adhoc clauses * sanitize remaining freeform clauses * sanitize adhoc having in frontend * address review comment (cherry picked from commit f341025)
mistercrunch
added
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for comments in adhoc clauses to make it easier to comment out sections of adhoc metrics/filters when developing charts. This is done by making sure that all freeform queries containing a single line comment
--are suffixed with a line change.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION