Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecating /my_queries endpoint #19524

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Apr 4, 2022

SUMMARY

We are doing a longer survey of the older api endpoints and migrating them to api/v1

During this we noticed that this particular endpoint is no longer being used in superset, nor is it publicly listed or in the swagger, therefore I think that it is ready to be depreciated, and potentially gotten rid of in the next major release.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Apr 4, 2022
@AAfghahi AAfghahi removed the Superset-Community-Partners Preset community partner program participants label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19524 (68681b0) into master (82a653f) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 68681b0 differs from pull request most recent head 448ce70. Consider uploading reports for the commit 448ce70 to get more accurate results

@@            Coverage Diff             @@
##           master   #19524      +/-   ##
==========================================
- Coverage   66.59%   66.59%   -0.01%     
==========================================
  Files        1678     1678              
  Lines       64242    64245       +3     
  Branches     6539     6539              
==========================================
+ Hits        42784    42785       +1     
- Misses      19763    19765       +2     
  Partials     1695     1695              
Flag Coverage Δ
hive 52.69% <66.66%> (+<0.01%) ⬆️
mysql 81.90% <66.66%> (-0.01%) ⬇️
postgres 81.95% <66.66%> (-0.01%) ⬇️
presto 52.54% <66.66%> (+<0.01%) ⬆️
python 82.38% <66.66%> (-0.01%) ⬇️
sqlite 81.72% <66.66%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/components/MenuRight.tsx 67.69% <ø> (ø)
superset/views/sql_lab.py 60.26% <66.66%> (+0.12%) ⬆️
superset/initialization/__init__.py 91.28% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a653f...448ce70. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "deprecating" in the title, not "depreciating"

@AAfghahi AAfghahi changed the title chore: Depreciating /my_queries endpoint chore: Deprecating /my_queries endpoint Apr 5, 2022
@AAfghahi
Copy link
Member Author

AAfghahi commented Apr 5, 2022

@betodealmeida these two words always mess me up :)

@AAfghahi AAfghahi merged commit 3f7b768 into apache:master Apr 5, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@dpgaspar dpgaspar deleted the ch154_my_queries_to_v1 branch January 20, 2023 11:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants