chore(database): Creating helper make_url_safe to wrap potential errors #19526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19526 +/- ##
==========================================
- Coverage 66.60% 66.43% -0.17%
==========================================
Files 1678 1678
Lines 64246 64257 +11
Branches 6539 6539
==========================================
- Hits 42788 42689 -99
- Misses 19763 19873 +110
Partials 1695 1695
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
approved these changes
Apr 5, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 5, 2022
…rs (apache#19526) * Creating helper make_url_safe to wrap potential errors * Fixing imports * Fixing imports again * Adding comment * Linting * Fixing test * Fixing test again... * Fixing import (cherry picked from commit f64d654)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 7, 2022
…rs (apache#19526) * Creating helper make_url_safe to wrap potential errors * Fixing imports * Fixing imports again * Adding comment * Linting * Fixing test * Fixing test again... * Fixing import (cherry picked from commit f64d654)
|
🏷️ preset:2022.11 |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…rs (apache#19526) * Creating helper make_url_safe to wrap potential errors * Fixing imports * Fixing imports again * Adding comment * Linting * Fixing test * Fixing test again... * Fixing import
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Quick PR to make DB URL parsing a bit easier to handle in the event of an error.