Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Athena timestamp literal format #19970

Merged
merged 6 commits into from
May 16, 2022
Merged

fix: Athena timestamp literal format #19970

merged 6 commits into from
May 16, 2022

Conversation

thinhnd2104
Copy link
Contributor

@thinhnd2104 thinhnd2104 commented May 6, 2022 •
edited
Loading

related: [#19969]
from AWS official docs

  • [ x] Has associated issue: [Timestamp literal Athena #19969]
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@thinhnd2104 thinhnd2104 changed the title Fix Athena timestamp literal format fix: Athena timestamp literal format May 7, 2022
@rusackas
Copy link
Member

Pinged for some reviews. Thanks for the contribution!

@john-bodley
Copy link
Member

@thinhnd2104 do you mind addressing the failed CI checks?

@thinhnd2104
Copy link
Contributor Author

@thinhnd2104 do you mind addressing the failed CI checks?

Thank you. This commit was updated.

@codecov
Copy link

codecov bot commented May 15, 2022 •
edited
Loading

Codecov Report

Merging #19970 (190a317) into master (f43dbc0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19970   +/-   ##
=======================================
  Coverage   66.37%   66.37%           
=======================================
  Files        1715     1715           
  Lines       64179    64179           
  Branches     6753     6753           
=======================================
  Hits        42602    42602           
  Misses      19859    19859           
  Partials     1718     1718
Flag Coverage Δ
hive 53.70% <0.00%> (ø)
mysql 82.04% <100.00%> (ø)
postgres 82.10% <100.00%> (ø)
presto 53.56% <0.00%> (ø)
python 82.53% <100.00%> (ø)
sqlite 81.84% <100.00%> (ø)
unit 49.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/athena.py 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43dbc0...190a317. Read the comment docs.

villebro
villebro approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro added the v1.5 label May 16, 2022
@villebro
Copy link
Member

@thinhnd2104 I pushed a commit to fix the linting error and will merge once CI passes.

@thinhnd2104
Copy link
Contributor Author

Thank you!

@villebro villebro merged commit 8531546 into apache:master May 16, 2022
@villebro
Copy link
Member

@thinhnd2104 thanks again for the fix; I'm tagging this for 1.5.1 which I'm hoping we'll get up for vote later this week

hiboyang pushed a commit to datapunchorg/superset that referenced this pull request May 19, 2022
@thinhnd2104 @villebro
fix: Athena timestamp literal format (apache#19970)
d6daa18 
* Fix Athena timestamp literal format

related: [apache#19969]

* Update test_athena.py

Update test

* Update athena.py

* Resolving CI/CD

* lint

Co-authored-by: Thinh Nguyen Duc <thinhnd.it@tripi.vn>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@villebro villebro added the v2.0 label May 24, 2022
@villebro villebro mentioned this pull request May 24, 2022
Closed
villebro pushed a commit that referenced this pull request May 26, 2022
@thinhnd2104 @villebro
fix: Athena timestamp literal format (#19970)
f50955e 
* Fix Athena timestamp literal format

related: [#19969]

* Update test_athena.py

Update test

* Update athena.py

* Resolving CI/CD

* lint

Co-authored-by: Thinh Nguyen Duc <thinhnd.it@tripi.vn>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
(cherry picked from commit 8531546)
michael-s-molina pushed a commit that referenced this pull request May 26, 2022
@thinhnd2104 @michael-s-molina
fix: Athena timestamp literal format (#19970)
bda9044 
* Fix Athena timestamp literal format

related: [#19969]

* Update test_athena.py

Update test

* Update athena.py

* Resolving CI/CD

* lint

Co-authored-by: Thinh Nguyen Duc <thinhnd.it@tripi.vn>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
(cherry picked from commit 8531546)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@thinhnd2104 @villebro @philipher29
fix: Athena timestamp literal format (apache#19970)
400c3ee 
* Fix Athena timestamp literal format

related: [apache#19969]

* Update test_athena.py

Update test

* Update athena.py

* Resolving CI/CD

* lint

Co-authored-by: Thinh Nguyen Duc <thinhnd.it@tripi.vn>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@thinhnd2104 thinhnd2104 deleted the patch-1 branch June 14, 2022 02:45
@mistercrunch mistercrunch added 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thinhnd2104 @rusackas @john-bodley @villebro @mistercrunch @michael-s-molina