Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Helm Chart): Support resource limits and requests for each component #20052

Merged
merged 3 commits into from
May 25, 2022
Merged

feat(Helm Chart): Support resource limits and requests for each component #20052

merged 3 commits into from
May 25, 2022

Conversation

rathberm
Copy link
Contributor

SUMMARY

We implemented the possibility to set individual resource limitations for every Superset component including supersetNode, supersetWorker and supersetCeleryBeat. For this reason, we added the values supersetNode.resources, supersetWorker.resources and supersetCeleryBeat.resources to the values file, the Helm Schema and the Helm Templates. These pod specific values overwrite the global resource limits and requests set via the values resources. This feature introduction will not break current deployments using the value resources and only implement additional functionality.
This change allows for a more customizable experience and a more optimized user experience when deploying Superset using the Helm Chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Using the command Helm template it is possible to verify if the resources limit and requests are set correctly.

ADDITIONAL INFORMATION

@craig-rueda
Copy link
Member

Pls bump the chart version

@rathberm
Copy link
Contributor Author

rathberm commented May 18, 2022

@craig-rueda I bumped the chart version

@craig-rueda craig-rueda merged commit 259e03e into apache:master May 25, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants