fix: Add french translation missing #20061

aehanno · 2022-05-13T18:55:04Z

SUMMARY

Adding french translation

Add Information

Fixes #20060

remove translation for datePicker

villebro

Thanks for the contributon @aehanno . I would recommend splitting this PR into multiple separate PRs, as there are many unrelated changes here. Specifically:

The additional French translations (completely valid)
Fixing the untranslated strings, like "Home" (this is completely valid)
using gettext instead of lazy_gettext (this is probably ok, but should be addressed in a separate PR, perhaps fixing other simiar instances)
Translating variables (these won't work)
Using moment to calculate the lastModified value fron changed_on instead of changed_on_humanized + adding last_run (this is controversial, but we can probably have that discussion in a separate PR)

villebro · 2022-05-16T08:07:23Z

superset-frontend/src/dashboard/components/SliceAdder.jsx

-              label: t('Sort by %s', label),
+              label: t('Sort by %s', t(label)),


This doesn't look right; you can't translate variables like this (the original code looks correct)

villebro · 2022-05-16T08:09:09Z

superset-frontend/src/dashboard/components/SliceAdder.jsx

-            lastModified={cellData.changed_on_humanized}
+            lastModified={moment.utc(cellData.changed_on).fromNow()}


This should not be changed (@dpgaspar can comment in more detail, but IIRC, the changed_on property needs to be constructed in the backend right now)

changed_on_humanized has no translation. I will be glade to keep 'changed_on_humanized' but what can I change so that the translation is done

I move the change on this PR : #20082
we can discuss about that on the new PR

villebro · 2022-05-16T08:09:15Z

superset-frontend/src/dashboard/components/dnd/AddSliceDragPreview.jsx

-      lastModified={slice.changed_on_humanized}
+      lastModified={moment.utc(slice.changed_on).fromNow()}


villebro · 2022-05-16T08:10:26Z

superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx

@@ -314,7 +314,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
      <Divider />
      <div>
        <div className="section-title">{t('Actual time range')}</div>
-        {validTimeRange && <div>{evalResponse}</div>}
+        {validTimeRange && <div>{t(evalResponse)}</div>}


Again, you can't translate a variable (please see e.g. https://stackoverflow.com/questions/34579316/flask-babel-how-to-translate-variables for an explanation why this is the case)

change has been move in this PR : #20080
We can discuss about translation of varaible in the ohter PR
Without the t() here, there is no translation, do you have an idea, where I can translate this

superset-frontend/src/views/CRUD/welcome/Welcome.tsx

…zed" PR

aehanno · 2022-06-06T15:41:59Z

Hello @villebro,
I created 4 other pr from this one
I pinned you on each one, I hope to get your feedback

mathieudruart · 2022-06-24T18:25:43Z

Hi @villebro Is there anything we can do to help move these PRs forward? Thanks!

villebro

LGTM, thanks for adding these missing translations!

villebro · 2022-07-12T05:36:33Z

@mathieudruart it appears you need to fix some linting errors in the translation file:

codecov · 2022-07-12T05:37:52Z

Codecov Report

Merging #20061 (5f1c6ec) into master (523bd8b) will decrease coverage by 0.48%.
The diff coverage is 77.24%.

❗ Current head 5f1c6ec differs from pull request most recent head 3d41d90. Consider uploading reports for the commit 3d41d90 to get more accurate results

@@            Coverage Diff             @@
##           master   #20061      +/-   ##
==========================================
- Coverage   66.55%   66.07%   -0.49%     
==========================================
  Files        1692     1732      +40     
  Lines       64802    65886    +1084     
  Branches     6657     6753      +96     
==========================================
+ Hits        43129    43532     +403     
- Misses      19973    20636     +663     
- Partials     1700     1718      +18

Flag	Coverage Δ
hive	`?`
mysql	`?`
postgres	`80.99% <ø> (-0.96%)`	⬇️
presto	`?`
python	`81.07% <ø> (-1.31%)`	⬇️
sqlite	`79.60% <ø> (-2.12%)`	⬇️
unit	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...art-controls/src/operators/contributionOperator.ts	`100.00% <ø> (ø)`
...-chart-controls/src/sections/advancedAnalytics.tsx	`14.28% <0.00%> (-19.05%)`	⬇️
...art-controls/src/sections/annotationsAndLayers.tsx	`100.00% <ø> (ø)`
...perset-ui-chart-controls/src/sections/sections.tsx	`100.00% <ø> (ø)`
.../shared-controls/components/RadioButtonControl.tsx	`0.00% <ø> (ø)`
...ges/superset-ui-core/src/query/buildQueryObject.ts	`100.00% <ø> (ø)`
...ges/superset-ui-core/src/query/extractTimegrain.ts	`100.00% <ø> (ø)`
...kages/superset-ui-core/src/query/getMetricLabel.ts	`100.00% <ø> (ø)`
...kages/superset-ui-core/src/query/processFilters.ts	`100.00% <ø> (ø)`
...superset-ui-core/src/query/types/PostProcessing.ts	`100.00% <ø> (ø)`
... and 463 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

aehanno · 2022-07-14T13:57:21Z

hey @villebro, correction of workflow has been made, it's possible to launch it ?
Thanks

mathieudruart · 2022-08-11T13:57:20Z

@mathieudruart it appears you need to fix some linting errors in the translation file:

Hi @villebro it should be fixed, is it possible to rerun the workflows ? Thanks !

mathieudruart · 2022-08-30T19:18:15Z

Hi @villebro do you know when this PR will be merged ? thank you !

villebro · 2022-08-30T20:23:33Z

Hey @mathieudruart , sorry for the delay; merged!

(cherry picked from commit 944808a)

aehanno added 3 commits May 12, 2022 17:06

add French translations

6ffca53

adding French translation

21c1c03

add French translations

d92bf95

remove translation for datePicker

pull-request-size bot added the size/XL label May 13, 2022

aehanno mentioned this pull request May 13, 2022

Missing French Translation #20060

Closed

5 tasks

villebro reviewed May 16, 2022

View reviewed changes

aehanno mentioned this pull request May 16, 2022

fix: Fixing untranslated FR strings #20078

Merged

aehanno added 3 commits May 16, 2022 10:08

remove some change that will be in an other PR

eb43b7a

remove some change that will be in "translating varaibles" PR

fb9c84d

remove some change that will be in "translate-changed_on_delta_humani…

5e741ff

…zed" PR

pull-request-size bot added size/L and removed size/XL labels May 16, 2022

fix: add french translation

6032030

villebro approved these changes Jul 12, 2022

View reviewed changes

aehanno added 4 commits July 12, 2022 16:41

fix : add translation

6eb0613

fix : correction translation

7da2812

fix : correction translation

338e336

fix : remove correction put in other PR

ba099e4

pull-request-size bot added size/XL and removed size/L labels Jul 14, 2022

aehanno added 2 commits July 14, 2022 09:27

fix : prettier on json file

3af150c

fix

1d270f4

aehanno added 2 commits July 14, 2022 11:18

fix

086c1df

Add new translation

1c459c9

fix

3d41d90

aehanno requested a review from villebro August 11, 2022 18:53

villebro merged commit 944808a into apache:master Aug 30, 2022

eschutho added v2.0 v2.0.1 labels Sep 20, 2022

eschutho pushed a commit that referenced this pull request Sep 20, 2022

fix: Add french translation missing (#20061)

f106f6e

(cherry picked from commit 944808a)

AAfghahi pushed a commit that referenced this pull request Oct 5, 2022

fix: Add french translation missing (#20061)

fc317e0

(cherry picked from commit 944808a)

AAfghahi pushed a commit that referenced this pull request Oct 6, 2022

fix: Add french translation missing (#20061)

5b662f7

(cherry picked from commit 944808a)

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add french translation missing #20061

fix: Add french translation missing #20061

aehanno commented May 13, 2022 •

edited

Loading

villebro left a comment •

edited

Loading

villebro May 16, 2022

aehanno May 16, 2022

villebro May 16, 2022

aehanno May 16, 2022 •

edited

Loading

villebro May 16, 2022

villebro May 16, 2022

aehanno May 16, 2022 •

edited

Loading

aehanno commented Jun 6, 2022

mathieudruart commented Jun 24, 2022 •

edited

Loading

villebro left a comment

villebro commented Jul 12, 2022

codecov bot commented Jul 12, 2022 •

edited

Loading

aehanno commented Jul 14, 2022

mathieudruart commented Aug 11, 2022

mathieudruart commented Aug 30, 2022

villebro commented Aug 30, 2022

		label: t('Sort by %s', label),
		label: t('Sort by %s', t(label)),

		lastModified={cellData.changed_on_humanized}
		lastModified={moment.utc(cellData.changed_on).fromNow()}

		lastModified={slice.changed_on_humanized}
		lastModified={moment.utc(slice.changed_on).fromNow()}

fix: Add french translation missing #20061

fix: Add french translation missing #20061

Conversation

aehanno commented May 13, 2022 • edited Loading

SUMMARY

Add Information

villebro left a comment • edited Loading

Choose a reason for hiding this comment

villebro May 16, 2022

Choose a reason for hiding this comment

aehanno May 16, 2022

Choose a reason for hiding this comment

villebro May 16, 2022

Choose a reason for hiding this comment

aehanno May 16, 2022 • edited Loading

Choose a reason for hiding this comment

villebro May 16, 2022

Choose a reason for hiding this comment

villebro May 16, 2022

Choose a reason for hiding this comment

aehanno May 16, 2022 • edited Loading

Choose a reason for hiding this comment

aehanno commented Jun 6, 2022

mathieudruart commented Jun 24, 2022 • edited Loading

villebro left a comment

Choose a reason for hiding this comment

villebro commented Jul 12, 2022

codecov bot commented Jul 12, 2022 • edited Loading

Codecov Report

aehanno commented Jul 14, 2022

mathieudruart commented Aug 11, 2022

mathieudruart commented Aug 30, 2022

villebro commented Aug 30, 2022

aehanno commented May 13, 2022 •

edited

Loading

villebro left a comment •

edited

Loading

aehanno May 16, 2022 •

edited

Loading

aehanno May 16, 2022 •

edited

Loading

mathieudruart commented Jun 24, 2022 •

edited

Loading

codecov bot commented Jul 12, 2022 •

edited

Loading