fix: Fixing untranslated FR strings

[aehanno]

SUMMARY

Fixing the untranslated strings

Add Information

Fixes #20060

[aehanno]

@villebro, PR you ask me to create from an other one

[codecov]

Codecov Report

Merging #20078 (5ec8f83) into master (bb1db9e) will decrease coverage by 0.08%.
Report is 188 commits behind head on master.
The diff coverage is 58.26%.

❗ Current head 5ec8f83 differs from pull request most recent head bf7c5ff. Consider uploading reports for the commit bf7c5ff to get more accurate results

@@            Coverage Diff             @@
##           master   #20078      +/-   ##
==========================================
- Coverage   69.08%   69.00%   -0.08%     
==========================================
  Files        1906     1905       -1     
  Lines       74114    74135      +21     
  Branches     8155     8211      +56     
==========================================
- Hits        51201    51160      -41     
- Misses      20794    20852      +58     
- Partials     2119     2123       +4     

Flag	Coverage Δ
hive	54.18% <ø> (+0.26%)	⬆️
mysql	79.21% <ø> (-0.19%)	⬇️
postgres	79.31% <ø> (-0.18%)	⬇️
presto	54.08% <ø> (+0.26%)	⬆️
python	83.31% <ø> (-0.18%)	⬇️
sqlite	?
unit	55.06% <ø> (+0.36%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx	100.00% <ø> (ø)
...et-ui-chart-controls/src/components/labelUtils.tsx	100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts	100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx	14.28% <ø> (ø)
...rset-ui-chart-controls/src/sections/chartTitle.tsx	100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts	100.00% <ø> (ø)
.../superset-ui-core/src/models/ExtensibleFunction.ts	100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts	100.00% <ø> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js	0.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx	57.14% <ø> (ø)
... and 153 more

... and 213 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

Left a few comments

[ETselikov]

@aehanno Hi! We are looking forward into improving translations as the same places you address in this PR. Are you planning on finishing your work here and merging it into master?

[aehanno]

@aehanno Hi! We are looking forward into improving translations as the same places you address in this PR. Are you planning on finishing your work here and merging it into master?

Hi @ETselikov, I'm a little block on this change #20078 (comment)
I don't have the list of values of the variable name

If you have any idea, I will do the change and merge my branch

[aehanno]

Hi @villebro, I just do the changes you request

can you do a review of the new code to merge the PR after

Thanks

[aehanno]

Hi @villebro and @Always-prog, I've resolved the conflicts, so can I have a review before I have any more ?

Thanks

[rusackas]

@villebro @michael-s-molina can you confirm or deny a concern here? It looks like this PR is editing the JSON files, which were (or could be) generated from the .po files, according to the docs: https://superset.apache.org/docs/contributing/translations/

Is it a risky/bad idea to make these updates this way? Should people be editing the .po files rather than .json?

[aehanno]

@villebro @michael-s-molina can you confirm or deny a concern here? It looks like this PR is editing the JSON files, which were (or could be) generated from the .po files, according to the docs: https://superset.apache.org/docs/contributing/translations/

Is it a risky/bad idea to make these updates this way? Should people be editing the .po files rather than .json?

Hi @rusackas, I used the script po2json.sh to generate json file from po file but All the translation with "#, fuzzy" are not display in the json file.
It's normal or not ?

Thanks for your answer

[rusackas]

Oh, ok, if this JSON was generated by the script, I think we're good. I feared you hand-edited the JSON and opened a PR (it wouldn't be the first time that's happened).

[aehanno]

Left a few comments

HI @villebro, I need your review to move this ticket forward.

Thanks

[rusackas]

@villebro the merging is blocked awaiting your review. Holler if you think there's more to work on here :) Thanks!

[aehanno]

Thanks @villebro and @rusackas for approvals. Do you know what's the next step to merge this PR now ?