Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add the tnum font property to Table components #20093

Merged
merged 1 commit into from
May 18, 2022
Merged

chore: Add the tnum font property to Table components #20093

merged 1 commit into from
May 18, 2022

Conversation

geido
Copy link
Member

@geido geido commented May 17, 2022

SUMMARY

Added the tnum property to the TableCollection component which is used in most lists and Time-series Table chart

BEFORE

lists_before

AFTER

lists_after

Added the tnum property to the Pivot Table v2 component

BEFORE

pivot_table_v2_before

AFTER

pivot_table_v2_after

Added the tnum property to the Pivot Table v1 component

BEFORE

pivot_table_before

AFTER

pivot_table_after

Added the tnum property to the Paired t-test table component

BEFORE

paired_t_test_before

AFTER

paired_t_test_after

CollectionTable used in the Datasource modal already has the tnum property. No additional changes are required. The same applies to all tables using Antdesign

FilterableTable used in the result set of SqlLab already has the tnum property. No additional changes are required. The same applies to all tables using react-virtualized

The viz type Table has the tnum property. No additional changes are required

TESTING INSTRUCTIONS

  1. Open all Tables as presented above
  2. Make sure the numbers in the cells are using the tnum font property
  3. Make sure all tables are still appearing as intended

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #20093 (b6f184f) into master (9854d2d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20093      +/-   ##
==========================================
- Coverage   66.37%   66.36%   -0.02%     
==========================================
  Files        1715     1716       +1     
  Lines       64179    64280     +101     
  Branches     6753     6796      +43     
==========================================
+ Hits        42602    42662      +60     
- Misses      19859    19888      +29     
- Partials     1718     1730      +12     
Flag Coverage Δ
javascript 51.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <ø> (ø)
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <ø> (ø)
superset-frontend/src/components/Chart/Chart.jsx 52.54% <ø> (ø)
...-frontend/src/components/TableCollection/index.tsx 100.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 34.48% <0.00%> (-5.52%) ⬇️
...end/src/components/Datasource/DatasourceEditor.jsx 65.20% <0.00%> (-4.17%) ⬇️
...plugins/plugin-chart-echarts/src/utils/forecast.ts 93.22% <0.00%> (-1.61%) ⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.40% <0.00%> (-1.24%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 56.86% <0.00%> (-1.04%) ⬇️
...d/plugins/plugin-chart-echarts/src/utils/series.ts 92.00% <0.00%> (-0.96%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9854d2d...b6f184f. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 1fe30f1 into apache:master May 18, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants