Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add the tnum font property to Table components #20093

Merged
merged 1 commit into from
May 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ const StyledDiv = styled.div`
margin-left: ${theme.gridUnit}px;
}

.reactable-data tr {
font-feature-settings: 'tnum' 1;
}

.reactable-data tr,
.reactable-header-sortable {
-webkit-transition: ease-in-out 0.1s;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ export const Styles = styled.div`
top: 0;
}

table tbody tr {
font-feature-settings: 'tnum' 1;
}

table.pvtTable thead tr th,
table.pvtTable tbody tr th {
background-color: ${theme.colors.grayscale.light5};
Expand Down
4 changes: 4 additions & 0 deletions superset-frontend/src/components/Chart/Chart.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ const Styles = styled.div`

.slice_container {
height: ${p => p.height}px;

.pivot_table tbody tr {
font-feature-settings: 'tnum' 1;
}
}
`;

Expand Down
1 change: 1 addition & 0 deletions superset-frontend/src/components/TableCollection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export const Table = styled.table`
}

.table-cell {
font-feature-settings: 'tnum' 1;
text-overflow: ellipsis;
overflow: hidden;
max-width: 320px;
Expand Down