Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use exc_info to pass errors to log warnings #20252

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jun 3, 2022

SUMMARY

After looking at our logs, I'm not seeing any exception information being passed through when written logger.warning(ex) so I'm updating all of these loggers to use exc_info=True instead.

https://docs.python.org/3/library/logging.html#logging.Logger.debug
By passing True we get the results of sys.exc_info https://docs.python.org/3/library/sys.html#sys.exc_info
We could alternatively pass the exception explicitly.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Jun 3, 2022
superset/views/base.py Outdated Show resolved Hide resolved
superset/views/base.py Outdated Show resolved Hide resolved
eschutho and others added 2 commits June 3, 2022 08:59
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
@eschutho eschutho removed the Superset-Community-Partners Preset community partner program participants label Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #20252 (3d74525) into master (74c5479) will increase coverage by 0.05%.
The diff coverage is 72.10%.

❗ Current head 3d74525 differs from pull request most recent head c99aaff. Consider uploading reports for the commit c99aaff to get more accurate results

@@            Coverage Diff             @@
##           master   #20252      +/-   ##
==========================================
+ Coverage   66.47%   66.52%   +0.05%     
==========================================
  Files        1726     1726              
  Lines       64767    64886     +119     
  Branches     6828     6832       +4     
==========================================
+ Hits        43055    43167     +112     
- Misses      19977    19987      +10     
+ Partials     1735     1732       -3     
Flag Coverage Δ
hive 53.66% <38.51%> (-0.04%) ⬇️
mysql 82.22% <86.76%> (+0.02%) ⬆️
postgres 82.29% <86.76%> (+0.02%) ⬆️
presto 53.52% <38.51%> (-0.04%) ⬇️
python 82.71% <86.76%> (+0.05%) ⬆️
sqlite 82.02% <86.76%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../shared-controls/components/RadioButtonControl.tsx 0.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
.../legacy-plugin-chart-world-map/src/controlPanel.ts 33.33% <0.00%> (-66.67%) ⬇️
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 32.62% <0.00%> (-0.54%) ⬇️
...tend/src/components/Datasource/DatasourceModal.tsx 69.04% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 60.60% <ø> (ø)
...set-frontend/src/explore/actions/exploreActions.ts 50.00% <ø> (ø)
...mponents/DataTablesPane/components/ResultsPane.tsx 58.18% <ø> (-0.75%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c5479...c99aaff. Read the comment docs.

@eschutho eschutho merged commit f270e49 into apache:master Jun 3, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants