Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: superset-ui/core code coverage #20304

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

increase superset-ui/core code coverage

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #20304 (c2cb305) into master (d3670f1) will not change coverage.
The diff coverage is n/a.

❗ Current head c2cb305 differs from pull request most recent head 27c3a34. Consider uploading reports for the commit 27c3a34 to get more accurate results

@@           Coverage Diff           @@
##           master   #20304   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files        1733     1733           
  Lines       64953    64953           
  Branches     6858     6858           
=======================================
  Hits        43268    43268           
  Misses      19929    19929           
  Partials     1756     1756           
Flag Coverage Δ
javascript 51.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3670f1...27c3a34. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 8e46ae5 into apache:master Jun 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants