Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve encrypted field adapter docs #21111

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Improved docs for SQLALCHEMY_ENCRYPTED_FIELD_TYPE_ADAPTER, provides an example on how to write a new adapter that changes the default encryption engine.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #21111 (90e76fe) into master (0c84203) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21111   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1770     1770           
  Lines       67543    67545    +2     
  Branches     7185     7185           
=======================================
+ Hits        44760    44762    +2     
  Misses      20944    20944           
  Partials     1839     1839           
Flag Coverage Δ
hive 53.17% <ø> (+<0.01%) ⬆️
mysql 80.95% <ø> (+<0.01%) ⬆️
postgres 80.99% <ø> (+<0.01%) ⬆️
presto 53.06% <ø> (+<0.01%) ⬆️
python 81.48% <ø> (+<0.01%) ⬆️
sqlite 79.61% <ø> (+<0.01%) ⬆️
unit 50.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.47% <ø> (ø)
superset/views/base.py 75.53% <0.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar merged commit db7e2b2 into apache:master Aug 17, 2022
@dpgaspar dpgaspar deleted the docs/encrypted_type_advisory branch August 17, 2022 15:08
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants