Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Renaming Line Chart to Line Chart v2 #21278

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

lauderbaugh
Copy link
Contributor

SUMMARY

If you have generic x-axis on, there are two charts called "Line Chart." This is confusing and incorrect since they are different charts. This update creates a naming distinction by updating the e-charts version to be "Line Chart v2."

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

  • Turn on the feature flag
  • Go to the visualization picker
  • Observe that the label now contains the 'v2' indicator

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: GENERIC_CHART_AXES
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

When generic x-axis is on; right now it's a duplicate label, which is confusing.
@lauderbaugh lauderbaugh changed the title Chore: Renaming Line Chart to Line Chart v2 chore: Renaming Line Chart to Line Chart v2 Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21278 (24b1f88) into master (a7fe485) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21278   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files        1784     1784           
  Lines       68236    68236           
  Branches     7265     7265           
=======================================
  Hits        45327    45327           
  Misses      21040    21040           
  Partials     1869     1869           
Flag Coverage Δ
javascript 52.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/Regular/Line/index.ts 33.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit 994f327 into apache:master Sep 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants