chore: Create dashboard with tier 1 and tier 2 charts #21551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21551 +/- ##
==========================================
+ Coverage 66.67% 66.83% +0.15%
==========================================
Files 1793 1798 +5
Lines 68540 68823 +283
Branches 7287 7333 +46
==========================================
+ Hits 45699 45996 +297
+ Misses 20979 20949 -30
- Partials 1862 1878 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
codyml
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Thanks for this! I tried running superset with CYPRESS_CONFIG=true to get it to load the dashboard into superset for manual checking and it seemed like some of them were missing/broken – I left comments for them. But, if I'm doing that wrong and that's making them break let me know!
| "meta": { | ||
| "chartId": 9, | ||
| "height": 50, | ||
| "sliceName": "Pie Chart", |
geido
reviewed
Sep 29, 2022
superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts
Show resolved
Hide resolved
geido
approved these changes
Sep 30, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR creates a test dashboard with 32 supported charts. The goal is to enable easily testing new dashboard features on every supported chart with cypress e2e test suites.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-09-29.at.22.33.35.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION