fix: accept old database payload

[betodealmeida]

SUMMARY

#21248 fixed a vulnerability issue where credentials stored in encrypted_extra were being displayed to all users who could see the database. Unfortunately the PR changed the schema used for databases CRUD (create, update, validate parameters, etc.) since one of the fields was renamed from encrypted_extra to masked_encrypted_extra. This is a breaking change that affected clients talking to Superset APIs.

This PR adds some pre-load validation to the schema, so that the old payload with encrypted_extra is still supported.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

I added a unit test.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21923 (2cb5874) into master (88e98d5) will decrease coverage by 9.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21923      +/-   ##
==========================================
- Coverage   65.51%   55.58%   -9.94%     
==========================================
  Files        1807     1807              
  Lines       69183    69191       +8     
  Branches     7405     7405              
==========================================
- Hits        45325    38459    -6866     
- Misses      21948    28822    +6874     
  Partials     1910     1910              

Flag	Coverage Δ
hive	52.92% <62.50%> (?)
mysql	?
postgres	?
presto	52.82% <62.50%> (?)
python	57.96% <100.00%> (-20.58%)	⬇️
sqlite	?
unit	51.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/databases/schemas.py	84.87% <100.00%> (-10.18%)	⬇️
superset/utils/dashboard_import_export.py	0.00% <0.00%> (-100.00%)	⬇️
superset/tags/core.py	4.54% <0.00%> (-95.46%)	⬇️
superset/key_value/commands/update.py	0.00% <0.00%> (-90.91%)	⬇️
superset/key_value/commands/delete.py	0.00% <0.00%> (-87.88%)	⬇️
superset/key_value/commands/delete_expired.py	0.00% <0.00%> (-84.00%)	⬇️
superset/dashboards/commands/importers/v0.py	15.62% <0.00%> (-76.25%)	⬇️
superset/datasets/commands/create.py	30.61% <0.00%> (-69.39%)	⬇️
superset/datasets/commands/update.py	25.00% <0.00%> (-69.05%)	⬇️
superset/datasets/commands/importers/v0.py	24.03% <0.00%> (-69.00%)	⬇️
... and 319 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM