Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display Error Messages in DB Connection Modal #22200

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Nov 22, 2022

SUMMARY

This PR is trying to dix issues where connection errors where showing up in the advanced tab as opposed to the basic tab in the sql alchemy uri connection modal.

Also, putting more information into the database connection modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-11-29.at.11.36.43.AM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #22200 (3a1eadf) into master (2bdf22b) will increase coverage by 11.15%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           master   #22200       +/-   ##
===========================================
+ Coverage   55.69%   66.85%   +11.15%     
===========================================
  Files        1846     1847        +1     
  Lines       70302    70821      +519     
  Branches     7689     7917      +228     
===========================================
+ Hits        39157    47347     +8190     
+ Misses      29151    21448     -7703     
- Partials     1994     2026       +32     
Flag Coverage Δ
hive 52.55% <ø> (ø)
javascript 53.87% <44.44%> (+0.07%) ⬆️
mysql 78.04% <ø> (?)
postgres 78.11% <ø> (?)
presto 52.45% <ø> (ø)
python 81.30% <ø> (+23.51%) ⬆️
sqlite 76.57% <ø> (?)
unit 50.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 41.78% <28.57%> (-0.21%) ⬇️
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 92.85% <100.00%> (+2.61%) ⬆️
...ilters/FilterBar/FilterControls/FilterControls.tsx 69.76% <0.00%> (-0.45%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 80.53% <0.00%> (-0.09%) ⬇️
...perset-frontend/src/views/RootContextProviders.tsx 0.00% <0.00%> (ø)
...et-frontend/src/filters/components/Select/types.ts 100.00% <0.00%> (ø)
...end/src/filters/components/Range/transformProps.ts 100.00% <0.00%> (ø)
...d/src/filters/components/GroupBy/transformProps.ts 0.00% <0.00%> (ø)
...src/filters/components/TimeGrain/transformProps.ts 0.00% <0.00%> (ø)
...rc/dashboard/util/useFilterFocusHighlightStyles.ts 100.00% <0.00%> (ø)
... and 312 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 29, 2022
@AAfghahi AAfghahi marked this pull request as ready for review November 29, 2022 16:27
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch from bf3145a to fb97563 Compare November 29, 2022 16:45
@apache apache deleted a comment from github-actions bot Nov 29, 2022
@apache apache deleted a comment from github-actions bot Nov 29, 2022
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch 2 times, most recently from 1ab490b to ee4aa62 Compare November 29, 2022 19:32
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending any QA/product reviews

@AAfghahi
Copy link
Member Author

AAfghahi commented Dec 1, 2022

@eschutho have you seen this docker error before? It's preventing me from building an ephemeral.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AAfghahi I was testing this with databricks, and it looks like we still need the validation errors if they are generic db connection issues.

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch from a289dea to a3df3da Compare December 1, 2022 16:20
: [];
} else if (
!isEmpty(validationErrors) &&
validationErrors?.error_type === 'GENERIC_DB_ENGINE_ERROR'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended to this @eschutho

@AAfghahi
Copy link
Member Author

AAfghahi commented Dec 1, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

@AAfghahi Ephemeral environment spinning up at http://35.161.176.24:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch from a3df3da to d0ba261 Compare December 1, 2022 19:56
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch 3 times, most recently from 314eca2 to d97a2ed Compare December 1, 2022 21:57
@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch from d97a2ed to 5730d3b Compare December 1, 2022 22:07
@yousoph
Copy link
Member

yousoph commented Dec 1, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

@yousoph Ephemeral environment spinning up at http://54.187.4.90:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi AAfghahi force-pushed the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch from a123697 to 3a1eadf Compare December 2, 2022 16:04
@AAfghahi
Copy link
Member Author

AAfghahi commented Dec 2, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

@AAfghahi Ephemeral environment spinning up at http://18.236.95.123:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho merged commit aafb993 into master Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash.afghahi/sc-61350/db-connect-error-msg-is-not-show-on-basic branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants