Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): make test chart time range deterministic #22567

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented Jan 2, 2023

SUMMARY

Cypress is currently failing due to a test chart having a "40 years ago" time range, causing the row count to drop by one every year (hence it's now 25 rows and not 26 rows):

image

Here we're changing the time range to be deterministic so we don't have to do this change annually. In addition, since and until are moved into time_range from the birth names defaults, as they're overlapping with time_range.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #22567 (0d9f45b) into master (734d423) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22567      +/-   ##
==========================================
- Coverage   66.91%   66.89%   -0.03%     
==========================================
  Files        1851     1851              
  Lines       70709    70709              
  Branches     7766     7766              
==========================================
- Hits        47316    47299      -17     
- Misses      21371    21387      +16     
- Partials     2022     2023       +1     
Flag Coverage Δ
hive 52.46% <ø> (ø)
mysql 77.95% <ø> (ø)
postgres 78.01% <ø> (-0.02%) ⬇️
presto 52.36% <ø> (ø)
python 81.21% <ø> (-0.07%) ⬇️
sqlite ?
unit 51.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/birth_names.py 70.00% <ø> (ø)
superset/db_engine_specs/sqlite.py 89.28% <0.00%> (-7.15%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 87.00% <0.00%> (-2.00%) ⬇️
superset/result_set.py 96.42% <0.00%> (-1.43%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/views/core.py 74.37% <0.00%> (-0.61%) ⬇️
superset/common/query_object.py 93.84% <0.00%> (-0.52%) ⬇️
superset/reports/commands/execute.py 91.66% <0.00%> (-0.34%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 38d02a1 into apache:master Jan 3, 2023
@villebro villebro deleted the villebro/unflake-cypress branch January 3, 2023 07:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants