Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spacing in alert modal #22709

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes the spacing in the alert modal. The control labels and the "Ignore cache when generating a screenshot" checkbox got a 4px top margin and the Notification Method dropdown had its left margin spacing removed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

alertModalBefore

AFTER:

alertModalAfter

TESTING INSTRUCTIONS

  • Go to the Alerts & reports page and click the "+ ALERT" button
  • Observe the spacing between elements

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #22709 (74433c1) into master (2de19f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #22709   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files        1869     1869           
  Lines       71605    71608    +3     
  Branches     7821     7821           
=======================================
+ Hits        48043    48046    +3     
  Misses      21534    21534           
  Partials     2028     2028           
Flag Coverage Δ
hive 52.59% <ø> (ø)
javascript 53.90% <100.00%> (+<0.01%) ⬆️
mysql 78.03% <ø> (ø)
postgres 78.10% <ø> (ø)
presto 52.48% <ø> (ø)
python 81.34% <ø> (ø)
sqlite 76.48% <ø> (ø)
unit 51.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 53.44% <100.00%> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lyndsiWilliams lyndsiWilliams merged commit 2ccdb72 into master Jan 13, 2023
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-alert-modal-spacing branch January 13, 2023 03:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants