Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re add upload tests #22753

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 17, 2023

SUMMARY

Pre transitioning to 2.0.0 upload tests were removed, these were "re found" while preparing 1.5.3.
This PR re adds them

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #22753 (1260c81) into master (6d37e66) will decrease coverage by 1.27%.
The diff coverage is 16.48%.

❗ Current head 1260c81 differs from pull request most recent head 7d2e13b. Consider uploading reports for the commit 7d2e13b to get more accurate results

@@            Coverage Diff             @@
##           master   #22753      +/-   ##
==========================================
- Coverage   67.13%   65.86%   -1.27%     
==========================================
  Files        1869     1876       +7     
  Lines       71656    71812     +156     
  Branches     7822     7863      +41     
==========================================
- Hits        48103    47299     -804     
- Misses      21526    22487     +961     
+ Partials     2027     2026       -1     
Flag Coverage Δ
hive 52.60% <ø> (ø)
mysql ?
postgres 78.63% <ø> (+0.50%) ⬆️
presto 52.49% <ø> (ø)
python 78.99% <ø> (-2.37%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/Sunburst/buildQuery.ts 0.00% <0.00%> (ø)
...plugins/plugin-chart-echarts/src/Sunburst/index.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Sunburst/transformProps.ts 0.00% <0.00%> (ø)
...gins/plugin-chart-echarts/src/Treemap/constants.ts 54.54% <ø> (ø)
.../plugins/plugin-chart-echarts/src/Treemap/types.ts 100.00% <ø> (ø)
superset-frontend/src/GlobalStyles.tsx 0.00% <ø> (ø)
superset-frontend/src/components/Modal/Modal.tsx 85.89% <25.00%> (-3.30%) ⬇️
...plugin-chart-echarts/src/Sunburst/controlPanel.tsx 28.57% <28.57%> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts 50.87% <75.00%> (-1.37%) ⬇️
... and 85 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can't help but wonder why these were removed, but I guess that's water under the bridge. Welcome back, tests!

@dpgaspar dpgaspar merged commit edcbf59 into apache:master Jan 17, 2023
@dpgaspar dpgaspar deleted the chore/re-add-upload-tests branch January 17, 2023 17:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants