-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add tests to SQL lab button components #22916
Conversation
0652f8a
to
747b52a
Compare
Codecov Report
@@ Coverage Diff @@
## master #22916 +/- ##
==========================================
+ Coverage 67.25% 67.31% +0.06%
==========================================
Files 1876 1876
Lines 72066 72066
Branches 7869 7869
==========================================
+ Hits 48470 48514 +44
+ Misses 21578 21534 -44
Partials 2018 2018
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but adding more reviewers for second opinions if they have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Made the following changes:
EstimateQueryCostButton
: added missing testsExploreCtasResultsButton
: added missing testsExploreResultsButton
: converted tests to RTLBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION