Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests to SQL lab button components #22916

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Made the following changes:

  • EstimateQueryCostButton: added missing tests
  • ExploreCtasResultsButton: added missing tests
  • ExploreResultsButton: converted tests to RTL

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@diegomedina248 diegomedina248 force-pushed the dm/sql-lab-button-component-tests branch from 0652f8a to 747b52a Compare January 31, 2023 01:43
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #22916 (747b52a) into master (b94052e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22916      +/-   ##
==========================================
+ Coverage   67.25%   67.31%   +0.06%     
==========================================
  Files        1876     1876              
  Lines       72066    72066              
  Branches     7869     7869              
==========================================
+ Hits        48470    48514      +44     
+ Misses      21578    21534      -44     
  Partials     2018     2018              
Flag Coverage Δ
hive 52.71% <ø> (ø)
mysql 78.68% <ø> (ø)
postgres 78.75% <ø> (?)
presto 52.61% <ø> (ø)
python 81.97% <ø> (+0.12%) ⬆️
sqlite 77.08% <ø> (?)
unit 51.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lLab/components/ExploreCtasResultsButton/index.tsx 8.33% <ø> (ø)
...c/SqlLab/components/ExploreResultsButton/index.tsx 100.00% <ø> (ø)
superset/databases/api.py 91.30% <0.00%> (+0.27%) ⬆️
superset/db_engine_specs/base.py 90.21% <0.00%> (+0.31%) ⬆️
superset/reports/commands/execute.py 92.00% <0.00%> (+0.33%) ⬆️
superset/views/base_api.py 98.44% <0.00%> (+0.38%) ⬆️
superset/common/query_object.py 94.35% <0.00%> (+0.51%) ⬆️
superset/sqllab/api.py 100.00% <0.00%> (+1.19%) ⬆️
superset/commands/importers/v1/utils.py 93.50% <0.00%> (+1.29%) ⬆️
superset/result_set.py 97.87% <0.00%> (+1.41%) ⬆️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but adding more reviewers for second opinions if they have time.

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 4873c09 into master Apr 24, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the dm/sql-lab-button-component-tests branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants