Skip to content

Commit

Permalink
chore: Add tests to SQL lab button components (apache#22916)
Browse files Browse the repository at this point in the history
  • Loading branch information
diegomedina248 authored and sebastianliebscher committed Apr 28, 2023
1 parent b168ccc commit 2a57b3a
Show file tree
Hide file tree
Showing 6 changed files with 194 additions and 70 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import React from 'react';
import configureStore from 'redux-mock-store';
import thunk from 'redux-thunk';
import { render } from 'spec/helpers/testing-library';
import { fireEvent, render } from 'spec/helpers/testing-library';
import { Store } from 'redux';
import {
initialState,
Expand Down Expand Up @@ -90,4 +90,49 @@ describe('EstimateQueryCostButton', () => {

expect(queryByText('Estimate selected query cost')).toBeTruthy();
});

it('renders estimation error result', async () => {
const { queryByText, getByText } = setup(
{},
mockStore({
...initialState,
sqlLab: {
...initialState.sqlLab,
queryCostEstimates: {
[defaultQueryEditor.id]: {
error: 'Estimate error',
},
},
},
}),
);

expect(queryByText('Estimate cost')).toBeTruthy();
fireEvent.click(getByText('Estimate cost'));

expect(queryByText('Estimate error')).toBeTruthy();
});

it('renders estimation success result', async () => {
const { queryByText, getByText } = setup(
{},
mockStore({
...initialState,
sqlLab: {
...initialState.sqlLab,
queryCostEstimates: {
[defaultQueryEditor.id]: {
completed: true,
cost: [{ 'Total cost': '1.2' }],
},
},
},
}),
);

expect(queryByText('Estimate cost')).toBeTruthy();
fireEvent.click(getByText('Estimate cost'));

expect(queryByText('Total cost')).toBeTruthy();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import configureStore from 'redux-mock-store';
import fetchMock from 'fetch-mock';
import thunk from 'redux-thunk';
import { fireEvent, render, waitFor } from 'spec/helpers/testing-library';
import { Store } from 'redux';
import { SupersetClientClass } from '@superset-ui/core';
import { initialState } from 'src/SqlLab/fixtures';

import ExploreCtasResultsButton, {
ExploreCtasResultsButtonProps,
} from 'src/SqlLab/components/ExploreCtasResultsButton';

const middlewares = [thunk];
const mockStore = configureStore(middlewares);

const getOrCreateTableEndpoint = `glob:*/superset/get_or_create_table/`;

const setup = (props: Partial<ExploreCtasResultsButtonProps>, store?: Store) =>
render(
<ExploreCtasResultsButton
table="test"
schema="test_schema"
dbId={12346}
{...props}
/>,
{
useRedux: true,
...(store && { store }),
},
);

describe('ExploreCtasResultsButton', () => {
const postFormSpy = jest.spyOn(SupersetClientClass.prototype, 'postForm');
postFormSpy.mockImplementation(jest.fn());

it('renders', async () => {
const { queryByText } = setup({}, mockStore(initialState));

expect(queryByText('Explore')).toBeTruthy();
});

it('visualize results', async () => {
const { getByText } = setup({}, mockStore(initialState));

postFormSpy.mockClear();
fetchMock.reset();
fetchMock.post(getOrCreateTableEndpoint, { table_id: 1234 });

fireEvent.click(getByText('Explore'));

await waitFor(() => {
expect(postFormSpy).toHaveBeenCalledTimes(1);
expect(postFormSpy).toHaveBeenCalledWith('http://localhost/explore/', {
form_data:
'{"datasource":"1234__table","metrics":["count"],"groupby":[],"viz_type":"table","since":"100 years ago","all_columns":[],"row_limit":1000}',
});
});
});

it('visualize results fails', async () => {
const { getByText } = setup({}, mockStore(initialState));

postFormSpy.mockClear();
fetchMock.reset();
fetchMock.post(getOrCreateTableEndpoint, {
status: 500,
body: { message: 'Unexpected all to v1 API' },
});

fireEvent.click(getByText('Explore'));

await waitFor(() => {
expect(postFormSpy).toHaveBeenCalledTimes(0);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import Button from 'src/components/Button';
import { exploreChart } from 'src/explore/exploreUtils';
import { SqlLabRootState } from 'src/SqlLab/types';

interface ExploreCtasResultsButtonProps {
export interface ExploreCtasResultsButtonProps {
table: string;
schema?: string | null;
dbId: number;
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';

import ExploreResultsButton, {
ExploreResultsButtonProps,
} from 'src/SqlLab/components/ExploreResultsButton';
import { OnClickHandler } from 'src/components/Button';

const setup = (
onClickFn: OnClickHandler,
props: Partial<ExploreResultsButtonProps> = {},
) =>
render(<ExploreResultsButton onClick={onClickFn} {...props} />, {
useRedux: true,
});

describe('ExploreResultsButton', () => {
it('renders', async () => {
const { queryByText } = setup(jest.fn(), {
database: { allows_subquery: true },
});

expect(queryByText('Create Chart')).toBeTruthy();
expect(screen.getByRole('button', { name: 'Create Chart' })).toBeEnabled();
});

it('renders disabled if subquery not allowed', async () => {
const { queryByText } = setup(jest.fn());

expect(queryByText('Create Chart')).toBeTruthy();
expect(screen.getByRole('button', { name: 'Create Chart' })).toBeDisabled();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { t } from '@superset-ui/core';
import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
import Button, { OnClickHandler } from 'src/components/Button';

interface ExploreResultsButtonProps {
export interface ExploreResultsButtonProps {
database?: {
allows_subquery?: boolean;
};
Expand Down

0 comments on commit 2a57b3a

Please sign in to comment.