feat(native-filters): allow cascading from time and numeric filters

[villebro]

SUMMARY

Currently filter cascading is only supported on value filters. This adds cascading to time and numerical filters. Since the time column control is now shared between the dependent filter and pre-filter sections, it will render the time column picker in either section that is relevant.

VIDEO

Demo of how time filters can now cascade:

cascading.filters.mp4

Value filter affecting numerical range:

dependent-2.mp4

TESTING INSTRUCTIONS

1. Add a time filter and value filter
2. Make the value filter dependent on the time filter
3. Notice how changing the time filter affects the value filter

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23319 (44bd92f) into master (33b758d) will decrease coverage by 0.02%.
The diff coverage is 47.29%.

❗ Current head 44bd92f differs from pull request most recent head bcea029. Consider uploading reports for the commit bcea029 to get more accurate results

@@            Coverage Diff             @@
##           master   #23319      +/-   ##
==========================================
- Coverage   67.52%   67.51%   -0.02%     
==========================================
  Files        1909     1909              
  Lines       73508    73470      -38     
  Branches     7988     7976      -12     
==========================================
- Hits        49639    49603      -36     
+ Misses      21819    21817       -2     
  Partials     2050     2050              

Flag	Coverage Δ
javascript	53.74% <46.57%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...end/src/dashboard/components/SliceHeader/index.tsx	87.50% <0.00%> (-1.98%)	⬇️
.../nativeFilters/FilterBar/CrossFilters/Vertical.tsx	11.11% <0.00%> (ø)
.../nativeFilters/FilterBar/CrossFilters/selectors.ts	10.00% <0.00%> (+0.90%)	⬆️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx	76.31% <0.00%> (-0.61%)	⬇️
...rsConfigModal/FiltersConfigForm/DependencyList.tsx	52.45% <ø> (ø)
superset/config.py	91.78% <ø> (ø)
...rc/dashboard/components/nativeFilters/selectors.ts	58.26% <14.28%> (-3.34%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	59.72% <30.00%> (-0.21%)	⬇️
...ard/components/FiltersBadge/DetailsPanel/index.tsx	86.36% <85.71%> (+4.14%)	⬆️
...d/src/dashboard/components/FiltersBadge/Styles.tsx	93.33% <91.66%> (+6.96%)	⬆️
... and 6 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

This was causing the time column select to fail on numerical range filter, as it validated that the selected column was numerical (obviously not the case).

[kgabryje]

LGTM

[fmannhardt]

Hi, this came just in time since I need this for a dashboard. I tried the PR applied on 2.1.0rc2 and it works well expect for an issue when trying to add additional filters when there is already a time range filter available.

Not at all knowledgeable on React but it seems some optional chaining was missing since some field can be undefined, here a patch that worked for me.

gh--apache--superset-40ba379-35901f8.patch

[villebro]

@fmannhardt I tried to simulate a scenario where additionalFilters would be undefined, but based on the type definitions and the functional code that I looked at it should always at a minimum be an empty array. Would you be able to post some additional context on how the error is happening, and maybe a stack trace when running master branch in dev server mode so that we can see when this is happening?

[fmannhardt]

Of course, I will try to get the dev server mode running but before that here the steps to reproduce:

• Have multiple filters on a dashboard with the first a time filter and the second a value filter
• Save the filters
• Edit the filters to add another filter
• An error is thrown and in .some(filter => dependencies.includes(filter.value)); dependencies seems to be undefined.

I will try to reproduce this on top of master instead of 2.1.0rc2

[mdeshmu]

@fmannhardt were you able to reproduce your issue on top of master?