Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows reload on default filter value error #23459

Conversation

michael-s-molina
Copy link
Member

SUMMARY

When configuring the default value of a filter, we could have a network/permission/etc error when retrieving the values of a particular column. This PRs adds the ability to reload the default value field for instances where the underlying error can be fixed and the user can proceed with the configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-03-22.at.14.06.13.mov

TESTING INSTRUCTIONS

1 - Simulate an error when retrieving the column values in the default value field
2 - Make sure there's an error message and the option to reload the field
3 - By fixing the underlying error, and reloading, the field should display normally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #23459 (ad13b18) into master (da3791a) will increase coverage by 11.36%.
The diff coverage is 86.44%.

❗ Current head ad13b18 differs from pull request most recent head cc168c5. Consider uploading reports for the commit cc168c5 to get more accurate results

@@             Coverage Diff             @@
##           master   #23459       +/-   ##
===========================================
+ Coverage   56.27%   67.63%   +11.36%     
===========================================
  Files        1907     1908        +1     
  Lines       73495    73733      +238     
  Branches     7977     7989       +12     
===========================================
+ Hits        41356    49871     +8515     
+ Misses      30091    21814     -8277     
  Partials     2048     2048               
Flag Coverage Δ
javascript 53.82% <75.38%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 35.71% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 40.00% <ø> (ø)
...src/Timeseries/Regular/SmoothLine/controlPanel.tsx 40.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <ø> (ø)
...s/plugin-chart-echarts/src/Timeseries/constants.ts 100.00% <ø> (ø)
...gin-chart-echarts/src/components/ExtraControls.tsx 0.00% <0.00%> (ø)
... and 44 more

... and 286 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reading the diff with "Hide Whitespace" made this change much easier to comprehend:
image

@michael-s-molina michael-s-molina merged commit b077314 into apache:master Mar 23, 2023
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants