Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update cross-filter tooltip text #23654

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

yousoph
Copy link
Member

@yousoph yousoph commented Apr 11, 2023

SUMMARY

Updating the tooltip text on the cross-filter icon in dashboards to reflect the behavior of cross-filters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Clipboard 2023-06-04 at 5 37 51 PM

After:
image

TESTING INSTRUCTIONS

  • On a dashboard, apply a cross filter from a chart
  • On the chart where cross-filtering was emitted from, hover over the cross-filter icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: DASHBOARD_CROSS_FILTERS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #23654 (9cf9170) into master (b35b5a6) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cf9170 differs from pull request most recent head 84a50eb. Consider uploading reports for the commit 84a50eb to get more accurate results

@@           Coverage Diff           @@
##           master   #23654   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        1920     1920           
  Lines       73990    73990           
  Branches     8092     8092           
=======================================
  Hits        50379    50379           
  Misses      21540    21540           
  Partials     2071     2071           
Flag Coverage Δ
javascript 54.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/dashboard/components/SliceHeader/index.tsx 90.56% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousoph yousoph changed the title Update cross-filter tooltip text chore: Update cross-filter tooltip text Apr 12, 2023
@yousoph yousoph marked this pull request as ready for review April 12, 2023 18:48
@yousoph yousoph merged commit 95d71ff into master Apr 13, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the yousoph-cross-filter-tooltip branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants